Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: pick one of installed themes #2

Open
CHerSun opened this issue Sep 13, 2023 · 5 comments
Open

Feature request: pick one of installed themes #2

CHerSun opened this issue Sep 13, 2023 · 5 comments

Comments

@CHerSun
Copy link

CHerSun commented Sep 13, 2023

Hi.

Could you add a selection of one of installed themes for light and dark mode? Like what automaticDark gives. Stock themes aren't the best ones for everyone.

@FaridZelli
Copy link
Owner

Hey Alexander, sorry for the late reply.

The reason I couldn't implement this feature is because Firefox doesn't support themed extension icons. As custom themes use different color schemes, Toggley's icon would no longer look consistent with the rest of the browser. I'll surely implement this feature if Firefox add support for themed icons in the future, like Android currently does for homescreen icons.

In the meantime I was thinking about making a simple theme switcher, similar to the one on MDN. I'm trying to figure out a way to add theme previews to the dropdown list.

@colemickens
Copy link

Hi @FaridZelli, could I "sponsor" you to add this, and/or would you have any guidance to how I could implement a very quick and dirty version of this?

@FaridZelli
Copy link
Owner

any guidance to how I could implement a very quick and dirty version of this?

The MDN project I've linked above is probably close to what you'd want. I appreciate the offer but unfortunately I do not have enough time to work on this at the moment. If you want Toggley to use a different light or dark theme, you can simply replace [email protected] and [email protected] in the background script with the desired theme's extension ID in about:debugging. You may also need to edit the icons to match the new theme.

@colemickens
Copy link

Thanks so much for the reply and guidance @FaridZelli! And thank you for the extension!

@FaridZelli
Copy link
Owner

You're very welcome Cole! Feel free to ask me anything if you need help in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants