Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Right Click Join] Some users do not have a Join Call option in the channel list. #29

Open
Farcrada opened this issue Jun 7, 2021 · 2 comments
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@Farcrada
Copy link
Owner

Farcrada commented Jun 7, 2021

Describe the bug
When the channel's limit is exceeded (i.e. more users than the limit has imposed are connected) Right Clicking users becomes a hit or miss, and only the amount of "allowed" (for a limit of 3 only 3 users out of the connected users) users will have the option this plugin provides.

To Reproduce
Right click users in a voice channel that has exceeded the limit (this elongates to right clicking them everywhere else).

Expected behaviour
Regardless of the channel limit; be able to right click users and join.

Screenshots
n/a

Please complete the following information:

  • OS: W10 64bit
  • Plugin version: latest
  • Better Discord (BD) Version: latest

Additional context
This is likely somewhere deeper than the plugin can easily reach and will require some research. So far getVoiceStatesForChannel only returns up to the limit of that channel (limit == 3? returns 3).

@Farcrada Farcrada added the bug Something isn't working label Jun 7, 2021
@Farcrada Farcrada self-assigned this Jun 7, 2021
Farcrada pushed a commit that referenced this issue Jun 7, 2021
There was some funky shit with uncaught promises and fetching just straight up being a bitch. Seems to be resolved now.

Also, there's an issue when there are more users connected than there are slots (i.e. exceeding the imposed limit on a voice channel)
More about that here: #29
@Farcrada
Copy link
Owner Author

Farcrada commented Jun 7, 2021

This is interesting. Much as with most stores not everything on the planet is cached/loaded, as won't be the case here.

image
This image leads me to believe there is a fetchChannel (or something of that nature) to update voice states or channels. Only problem now is how to reliably fetch channels and without spamming or angering the API. 🤔

@Farcrada Farcrada changed the title [BUG] [Right Click Join] When channel limit is exceeded, right click is unreliable. [Right Click Join] When channel limit is exceeded, right click is unreliable. Jun 24, 2021
@Farcrada
Copy link
Owner Author

Farcrada commented Jun 24, 2021

It is in fact not the plugin that has it wrong. The user that you are attempting to right click is not connected to that channel.

In my side by side testing I found out that they would show up in a channel and have only one instance represent that (the older session). The plugin would retrieve that user's current state but since it is bugged in the channel list it won't show a context item; meaning they are not actually in a/that voice channel which is represented by the retrieving of that user's current state.

This is mostly found on the bigger servers, with lots of users connecting and disconnecting to voice channels along with session age.

@Farcrada Farcrada added the wontfix This will not be worked on label Jun 24, 2021
@Farcrada Farcrada reopened this Jun 24, 2021
@Farcrada Farcrada changed the title [Right Click Join] When channel limit is exceeded, right click is unreliable. [Right Click Join] Some users do not have a Join Call option in the channel list. Jun 24, 2021
Repository owner locked and limited conversation to collaborators Jul 16, 2021
@Farcrada Farcrada pinned this issue Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant