Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build process not triggering for sub components #40

Open
unoriginalscreenname opened this issue Jul 1, 2015 · 2 comments
Open

Build process not triggering for sub components #40

unoriginalscreenname opened this issue Jul 1, 2015 · 2 comments

Comments

@unoriginalscreenname
Copy link

I noticed something with the automated build and browser refresh. If i am working inside a sub-component, the build process will trigger and refresh the browser, but the changes will not take effect unless I make a change to the parent component that is being included in the public index file.

example... I am loading this layout component in the public index.htm:

FamousFramework.deploy('username:layout', 'HEAD', 'body');

inside layout, my node tree looks like this, loading two sub components:

<node id="layout">
    <component1></component1>
<component2></component2>
</node>

If i make changes to either of the subcomponents, the build process goes, but no changes are displayed in the browser. If i save the parent "layout" component, the changes take effect.

This might be the way it was intended to work. if so that is alright. it's just not the way i expected it to behave. Hope this is helpful.

@djgrant
Copy link

djgrant commented Jul 1, 2015

A temporary fix is to build all components on every change by adding --rebuildEverythingOnChange=yes to the "local-only-bootstrap": setting in the package.json.

You might want to clear some of the famous components you're not using out of components/famous to speed the build process up if you're doing that.

See #30

@matthewtoast
Copy link
Contributor

We'll also be adding another option soon that will allow you to develop with respect to a single component (instead of everything you have in your components folder), which also really speeds up the rebuilds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants