New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node attributes inconsistently added to DOM node #38

Open

djgrant opened this issue Jun 30, 2015 · 1 comment

djgrant commented Jun 30, 2015

Take this tree:

<node id="el" class="needs-css-styling">
  <h1>Hello</h1>
</node>

Without applying certain behaviors, this generates a DOM node without the id or the class given to the node.

<div class="famous-dom-element" data-fa-path="body/0/0/0/0" style="transform: matrix3d(1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1); width: 280px; height: 669px; display: block; opacity: 1;"><div class="famous-dom-element-content" style="width: 280px; height: 669px;"><h1 repeat-info="{&quot;$index&quot;:0,&quot;$repeatPayload&quot;:{}}">Hello</h1></div></div>

It would make more sense if attributes are passed to the DOM node irrespective of what behaviors are being applied.

The text was updated successfully, but these errors were encountered:

Contributor

matthewtoast commented Jun 30, 2015

Great catch. We'll look more into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment