Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack overflow in hard_reset when not using power pin #87

Open
diekleinekuh opened this issue Sep 30, 2023 · 2 comments · May be fixed by #91
Open

Stack overflow in hard_reset when not using power pin #87

diekleinekuh opened this issue Sep 30, 2023 · 2 comments · May be fixed by #91

Comments

@diekleinekuh
Copy link

We have some rare crashes in the wild which we traced back to an issue in https://github.com/BlackbirdHQ/ublox-cellular-rs/blob/master/ublox-cellular/src/power.rs:

hard_reset calls power_on at the end which in turn will try a soft_reset in case the power pin is not used. If this fails too hard_reset is called which closes the loop.

@MathiasKoch
Copy link
Member

That's a nice catch!

I can take a look as soon as I get a few minutes, unless you would like to add a PR for it?

@diekleinekuh
Copy link
Author

I will do a local fix first anyway and can try to do a PR if I have something that works. I would probably try to move the hard reset out of power_on and call it explicitly where it is needed. But I didn't look at the full picture yet.

@MathiasKoch MathiasKoch linked a pull request Oct 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants