Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for 'SubAck' #34

Open
MathiasKoch opened this issue Aug 25, 2021 · 0 comments
Open

Fix support for 'SubAck' #34

MathiasKoch opened this issue Aug 25, 2021 · 0 comments
Labels
bug 🐛 Something isn't working

Comments

@MathiasKoch
Copy link
Member

Currently SubAck packets are silently ignored, as the responseCode array needs to be handled correctly.

See https://github.com/BlackbirdHQ/mqttrust/blob/1600266795bcc5d3f33e566d5574a3ee4d5fc638/mqttrust/src/encoding/v4/subscribe.rs#L286-L308

And

https://github.com/BlackbirdHQ/mqttrust/blob/1600266795bcc5d3f33e566d5574a3ee4d5fc638/mqttrust_core/src/state.rs#L191-L199
@MathiasKoch MathiasKoch added the bug 🐛 Something isn't working label Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MathiasKoch