Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fileupload ACL not working on onAjax_download() #2180

Open
ariouche opened this issue Aug 5, 2019 · 4 comments
Open

fileupload ACL not working on onAjax_download() #2180

ariouche opened this issue Aug 5, 2019 · 4 comments

Comments

@ariouche
Copy link

ariouche commented Aug 5, 2019

$this->canView() line 3361 doesn't seem to be working

In addition, if (empty($row)) line 3377 always returns false even of the object is empty so I suggest to cast it to array in order to validate the test:
if (empty((array)$row))

@ariouche
Copy link
Author

Hello guys. Any news on this issue?

@cheesegrits
Copy link
Member

The canView() seems to be working OK for me:

https://www.screencast.com/t/K3ojYlpmY

I've changed that empty() test to cast to array as per your suggestion.

1cc334d

@ariouche
Copy link
Author

Great
I've also found that when a user isn't allowed to download a file, he can do it directly using the Ajax url

index.php?option=com_fabrik&task=plugin.pluginAjax&plugin=fileupload&method=ajax_download&format=raw&element_id=4088&formid=182&rowid=1&repeatcount=0&ajaxIndex=

@ariouche
Copy link
Author

Hello guys. Any news on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants