<STRUCTURE>_HAS_STRUCTURE biome tag fields should be renamed to HAS_<STRUCTURE> #3661
Labels
bug
Fixes or discusses a bug within the mappings
discussion
refactor
A PR that renames existing names.
Example of what I am seeing in 1.20 Yarn BiomeTags class:
![image](https://private-user-images.githubusercontent.com/40846040/266864282-a35ee961-512f-45a7-b7be-bb460ec9f827.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk3MDYwMzEsIm5iZiI6MTcxOTcwNTczMSwicGF0aCI6Ii80MDg0NjA0MC8yNjY4NjQyODItYTM1ZWU5NjEtNTEyZi00NWE3LWI3YmUtYmI0NjBlYzlmODI3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MzAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjMwVDAwMDIxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc2YTQxYWNhNmY3YmRhYmQ0ODgzMTc4Y2MzNjhjMzVhMWRmMzA5MzlkNjg0ZGI3NTM0ZTMxNGRhNjY5YWMwY2YmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.5By4EHHNpZQAFNQxjFlt3z9FvjSIZqntSJ3nXGB_bVI)
Personally, I feel this is a cause where it should break out of the <inner_tag>_<outer_folder> format in favor of cleaner readability.
In this case, I propose HAS_<inner_tag>. Or HAS_STRUCTURE_<inner_tag> which still reads better that current situation
The text was updated successfully, but these errors were encountered: