-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concurrency issue with ZipFileSystemProvider.newFileSystem #7
Comments
It is tbd whether this should be changed in tiny-remapper. Right now it assumes none of the inputs were opened elsewhere and cleans up after itself. The global state of FileSystems is unfortunate, especially once someone closes them... |
Interesting, so are you saying something else in the FabricMC stack opened the file or something outside entirely? This build was in CI so I'd assume only something within the FabricMC stack could be the culprit. |
Yes it's most certainly a (known) issue in Loom (Fabric's gradle plugin), it doesn't reliably close files and is being reworked. |
Cool, is there an open issue there I can subscribe to? Took a cursory look
and didn't see one.
…On Tue, Mar 26, 2019 at 19:31 Player ***@***.***> wrote:
Yes it's most certainly a (known) issue in Loom (Fabric's gradle plugin),
it doesn't reliably close files and is being reworked.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQlpVJvv0EYCqgJz8kK1zmlT_Y_eWhPks5vatgHgaJpZM4cKuyV>
.
|
If you can find a way to re-produce it, that would help a lot, especially if its on a local system. I fixed most of the locked file issues, and I know of one that is still around. But that last one only affects gen sources. As your issue seems a little different from what ive seen in the either make a new issue, or add to the following. Thanks. |
I am going to leave a comment on this as well. The link to the Loom PR: FabricMC/fabric-loom#156 |
This can be closed with 8f65b51 @sfPlayer1 |
ZipFileSystemProvider
can only provide oneFileSystem
instance per URI. I'm getting aFileSystemAlreadyExistsException
when building a mod in CircleCI. Here's a sample log: https://pastebin.com/5MjxLqfdThe text was updated successfully, but these errors were encountered: