Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod template generator: various improvements #35

Open
1 of 4 tasks
xpple opened this issue Feb 3, 2023 · 3 comments · Fixed by #43
Open
1 of 4 tasks

Mod template generator: various improvements #35

xpple opened this issue Feb 3, 2023 · 3 comments · Fixed by #43

Comments

@xpple
Copy link

xpple commented Feb 3, 2023

Here are a few improvements I can think of.

  • Create a test(mod) entrypoint along with the main and client entrypoints
  • Change tabs (\t) in ExampleMod and in ExampleModClient to spaces
  • Fix the entrypoint being com.example.ExampleMod(Client), as it should be com.example.examplemod.ExampleMod(Client)
  • Add inputs for the mod description, license, etc
@MichaelHillcox
Copy link
Contributor

Hey, looking at these issues now, do you have an example of what the test mod would look like? And could you clarify what you mean by

Fix the entrypoint being com.example.ExampleMod(Client), as it should be com.example.examplemod.ExampleMod(Client)

Technically, the package name and the entry points are all correct but that could be disputed as some people put their code in their com.example group whereas some people might put it within their modid and group com.example.examplemod

@modmuss50
Copy link
Member

Reopened as not all of this issue was fixed. 👍

@xpple
Copy link
Author

xpple commented Apr 24, 2023

Reopened as not all of this issue was fixed. 👍

I have edited my comment to have check boxes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants