Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sugestion: Use a more user friendly name for the profile created during install #46

Open
calloatti opened this issue Jul 23, 2020 · 4 comments
Assignees

Comments

@calloatti
Copy link

Instead of this: (fabric-loader-1.15.2)

image

This: (Fabric-1.15.2)

image

@TheBrokenRail
Copy link

If you are going to make things title-case, why not remove the hyphen as well?

@modmuss50 modmuss50 self-assigned this Aug 19, 2020
@haykam821
Copy link

It seems like this can't be changed without potentially causing duplicate installations as well. Perhaps something more reasonable, like the UUID that the launcher uses, can be used as a key instead?

@sfPlayer1
Copy link
Contributor

We can actively handle duplicates though, potentially prompting the user for whether it should replace the existing entry or add a new one (Fabric 1.15.2 #2, Fabric 1.15.2 #3, ...)

@calloatti
Copy link
Author

calloatti commented May 16, 2021

The name the user sees in the UI for an instance is the "name" property value, not the key for the instance in launcher_profiles.json

Mojang seems to use a guid for instance keys.

The fact that the Fabric installer uses the same value for "name" and the instance key may not be ideal, should probably do what the launcher itself does, generate a guid and use that as the instance key.

So there is no need to handle duplicate instance names, even the launcher does not check for that:

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants