Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mixin hotswapping tutorial #108

Closed
modmuss50 opened this issue Jun 5, 2024 · 8 comments
Closed

Remove mixin hotswapping tutorial #108

modmuss50 opened this issue Jun 5, 2024 · 8 comments
Labels
needs-further-discussing This doesn't seem right.

Comments

@modmuss50
Copy link
Member

This is an advanced feature that is not supported by all JVMs and is prone to error. I do plan on adding an option to loom to solve some of these issues. I dont think we should suggest for all users to set this when they are unlikely to ever use it.

@LlamaLad7
Copy link

It's a fairly commonly used feature, back when mixinextras caused a few issues with it I had many requests for it to be fixed. What JVMs doesn't it work on exactly? I've never had any issues with various Hotspot JVMs and almost no one uses OpenJ9.

@modmuss50
Copy link
Member Author

It's a fairly commonly used feature

I wasnt aware of that, if thats the case then making it easier to use should be a higher priortiy. I have personally never used it before :D

JVMs doesn't it work on exactly

Ss far as I know it doenst work on DCEVM/JBR. I would be happy to be wrong though.

@LlamaLad7
Copy link

It's incredibly useful for debugging and when set up correctly doesn't fail or cause any issues. I will test on JBR

@LlamaLad7
Copy link

Doesn't seem to work with -XX:+AllowEnhancedClassRedefinition on but otherwise is fine on JBR. I've always found DCEVM much more temperamental than Mixin hotswap so that by no means invalidates it.

@IMB11
Copy link
Member

IMB11 commented Jun 5, 2024

Yeah I'm gonna say no on this, Mixin hotswapping is extremely useful and easier to set up than DCEVM in the view of new mod developers.

@IMB11 IMB11 added the needs-further-discussing This doesn't seem right. label Jun 12, 2024
@JR1811
Copy link
Contributor

JR1811 commented Jun 13, 2024

I can confirm, I use hotswaps on mixins pretty often too.
The only problem is that it's a bit annoying to set up. So explaining it in the docs saves me some time for sure.

@leo60228
Copy link

Doesn't seem to work with -XX:+AllowEnhancedClassRedefinition on but otherwise is fine on JBR.

It works for me (I'm currently on JBR 21.0.3b465.3), though the added capabilities don't work for mixin classes.

@modmuss50
Copy link
Member Author

I'll close this then, will still look to improve in loom.

@modmuss50 modmuss50 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-further-discussing This doesn't seem right.
Projects
None yet
Development

No branches or pull requests

5 participants