Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Inline Control #22

Closed
andrewspy opened this issue Oct 29, 2017 · 5 comments
Closed

Feature Request: Inline Control #22

andrewspy opened this issue Oct 29, 2017 · 5 comments

Comments

@andrewspy
Copy link

Great work for the carousel component, I would like to request inline control, which is pretty common for modern web.

If there is no intention to implement it for whatever reason, I hope an example in the demo will show user how it can be done using the following hacky CSS mixin:-

/* Make control inline */
skeleton-carousel {
  --skeleton-carousel-controls-horizontal: {
    position: fixed;
    margin-top: calc(300px - 56px); /* 300px is the min-height of carousel */
    width: 100%;
  }
}

Thanks again!

@ernysans
Copy link
Member

@andrewspy We don't plan to add this for our next release but we can consider it in a couple of weeks, we are working on several components at this moment.
@stivaliserna please take note so we can review it for a future version.

@ernysans
Copy link
Member

@andrewspy I recommend you to apply position absolute to --skeleton-carousel-nav-prev and --skeleton-carousel-nav-next for now. We try not to use it at this time but can be helpful for what you need.

@andrewspy
Copy link
Author

@ernysans Noted. Thanks!

@andrewspy
Copy link
Author

I have made some changes on using CSS mixin to fix iOS and alignment issue, with a smaller dots. Just for sharing purpose.

/* Make controls inline */
skeleton-carousel {
  --skeleton-carousel-controls-horizontal: {
    position: absolute;
    margin-top: calc(300px - 40px); /* 300px is the min-height of carousel */
    width: calc(100% - 16px);
  }

  /* Make dots smaller */
  --skeleton-carousel-dot: {
    width: 24px;
    height: 24px;
    padding: 4px;
  }
}

@ernysans
Copy link
Member

Will be implemented with this issue -> #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants