Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spacefm-thermitegod-git fails to build #48

Open
FabioLolix opened this issue Dec 17, 2024 · 1 comment
Open

spacefm-thermitegod-git fails to build #48

FabioLolix opened this issue Dec 17, 2024 · 1 comment

Comments

@FabioLolix
Copy link
Owner

It can't find glaze.hpp despite adding the git submodule 0d2e3e2

There are also several warning abotu both ztd and glaze, like

meson.build:338: WARNING: include_directories sandbox violation!
The project is trying to access the directory 'subprojects/glaze/include' which belongs to a different
subproject. This is a problem as it hardcodes the relative paths of these two projects.
This makes it impossible to compile the project in any other directory layout and also
prevents the subproject from changing its own directory layout.

Instead of poking directly at the internals the subproject should be executed and
it should set a variable that the caller can then use. Something like:

# In subproject
some_dep = declare_dependency(include_directories: include_directories('include'))

# In subproject wrap file
[provide]
some = some_dep

# In parent project
some_dep = dependency('some')
executable(..., dependencies: [some_dep])

This warning will become a hard error in a future Meson release.
@FabioLolix
Copy link
Owner Author

Note to self, there are options to use the system's version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant