Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving NiftiImage fetch semantics #26

Open
vijayiyer05 opened this issue Oct 27, 2022 · 1 comment
Open

Improving NiftiImage fetch semantics #26

vijayiyer05 opened this issue Oct 27, 2022 · 1 comment

Comments

@vijayiyer05
Copy link

vijayiyer05 commented Oct 27, 2022

Per comment, the two-step of first fetch and then getting data for NiftiImage objects retrieved from map objects may feel strange to users.

Possible improvement:

  • Create a dependent property called NiftiImageInfo that does what fetch currently does
  • Replace fetch method with a getNiftiImage method which actually gets the image data
@dickscheid
Copy link
Contributor

This is a bit tricky, since in siibra fetch is always the step "outside" siibra, ie. going from a siibra object to a non-siibra (but highly interoperable) data type like NIfTI or pandas DataFrame. To be discussed further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants