cannot calibrate ETB/TPS without accel pedal

[nmschulte]

EtbController won't return successful init unless there's an accel pedal present: https://github.com/FOME-Tech/fome-fw/blob/master/firmware/controllers/actuators/electronic_throttle.cpp#L165

This seems unnecessary, for both TPS auto-calibration and PID autotune.

Perhaps init should remove this check? Unsure how ETB pedal target (m_pedalMap) would behave if no channels configured.

[mck1117]

That seems like a reasonable restriction, why would somebody run an ETB without a pedal?

[nmschulte]

mck1117 commented

why would somebody run an ETB without a pedal?

nmschulte commented

This seems unnecessary, for both TPS auto-calibration and PID autotune.

---

At the time, I had no need for a pedal -- bench testing/development I suppose.

It's no big deal if this restriction remains, but it didn't seem useful to me at the time, even in practice: you can command ETB through TS without a pedal in various ways.

Feel free to close if you don't want to see it change.