Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractManager interface only allows for one mount. #187

Open
jennydaman opened this issue Jan 22, 2022 · 0 comments
Open

AbstractManager interface only allows for one mount. #187

jennydaman opened this issue Jan 22, 2022 · 0 comments

Comments

@jennydaman
Copy link
Collaborator

def schedule_job(self, image, command, name, resources_dict, mountdir=None):

pman/pman/resources.py

Lines 54 to 55 in 54e2a43

self.str_app_container_inputdir = '/share/incoming'
self.str_app_container_outputdir = '/share/outgoing'

It would be better if multiple mounts were supported, and with mount options, such as mounting a volume read-only v.s. read-write. With DS plugins it is preferred to run them as such

docker run --rm -v /data/in:/incoming:ro -v /data/out:/outgoing:rw fnndsc/pl-whatever whatever /incoming /outgoing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant