Minor coding style adjustments

Author: FMCorz

classes/condition.php

@@ -23,7 +23,6 @@
  */
 
 namespace availability_stash;
-defined('MOODLE_INTERNAL') || die();
 
 use block_stash\manager;
 use block_stash\stash;
@@ -41,12 +40,18 @@
  */
 class condition extends \core_availability\condition {
 
+    /** Equal condition. */
     const EQUAL = '==';
+    /** Less than condition. */
     const LESSTHAN = '<';
+    /** More than condition. */
     const MORETHAN = '>';
 
+    /** @var string The condition. */
     protected $condition = self::EQUAL;
+    /** @var int The quantity. */
     protected $quantity = 1;
+    /** @var int|null The object ID. */
     protected $objectid = null;
 
     /**
@@ -120,7 +125,7 @@ public function is_available($not, \core_availability\info $info, $grabthelot, $
      *
      * @param bool $full Set true if this is the 'full information' view.
      * @param bool $not Set true if we are inverting the condition.
-     * @param info $info Item we're checking.
+     * @param \core_availability\info $info Item we're checking.
      * @return string Information string (for admin) about all restrictions on this item.
      */
     public function get_description($full, $not, \core_availability\info $info) {
@@ -185,6 +190,7 @@ protected function get_generic_description($not) {
     /**
      * Get the name of the object in this rule.
      *
+     * @param \core_availability\info $info Availability info.
      * @return string
      */
     protected function get_object_name(\core_availability\info $info) {

classes/frontend.php

@@ -23,7 +23,6 @@
  */
 
 namespace availability_stash;
-defined('MOODLE_INTERNAL') || die();
 
 use block_stash\manager;
 
@@ -86,8 +85,8 @@ protected function get_javascript_init_params($course, \cm_info $cm = null, \sec
                 // Yes, it's very unreadable...
                 $name = format_string($item->get_name(), true, ['context' => $manager->get_context()]);
                 return (object) ['id' => $item->get_id(), 'name' => $name];
-            }, $items)
-        ]];
+            }, $items),
+        ], ];
     }
 
 }

classes/privacy/provider.php

@@ -24,9 +24,7 @@
 
 namespace availability_stash\privacy;
 
-defined('MOODLE_INTERNAL') || die();
-
-use \core_privacy\local\metadata\null_provider;
+use core_privacy\local\metadata\null_provider;
 
 /**
  * Privacy class for requesting user data.
@@ -45,7 +43,7 @@ class provider implements null_provider {
      *
      * @return  string
      */
-    public static function _get_reason() {
+    public static function _get_reason() { // @codingStandardsIgnoreLine
         return 'privacy:null';
     }
 }

version.php

@@ -29,6 +29,6 @@
 $plugin->component = 'availability_stash';
 $plugin->release   = '1.2.1';
 $plugin->maturity  = MATURITY_STABLE;
-$plugin->dependencies = array(
+$plugin->dependencies = [
     'block_stash'  => 2016052300,
-);
+];