Skip to content

disable stats and update subject #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SivaKaviyappa wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

disable stats and update subject #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metastor/managedObjectLoader/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<parent>
<artifactId>metastore</artifactId>
<groupId>org.finra.herd-mdl.metastore</groupId>
<version>1.2.65</version>
<version>1.2.66</version>
</parent>

<modelVersion>4.0.0</modelVersion>
Expand Down
6 changes: 6 additions & 0 deletions ...anagedObjectLoader/src/main/java/org/finra/herd/metastore/managed/NotificationSender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,12 @@ public void sendFailureEmail( JobDefinition od, int numRetry, String errorLog, S
sendNotificationEmail( getMessageBody( od, errorLog, clusterID ), subject, od );
}

public void sendFailureEmail( JobDefinition od, int numRetry, String errorLog, String subject ,String clusterID) {
String sub = String.format(subject+" %d Retries", numRetry );
sendNotificationEmail( getMessageBody( od, errorLog, clusterID ), sub, od );
}


protected String getAction( JobDefinition od ) {
String action = "Add Partition";
if ( od.getWfType() == ObjectProcessor.WF_TYPE_MANAGED_STATS ) {
Expand Down
13 changes: 7 additions & 6 deletions ...ectLoader/src/main/java/org/finra/herd/metastore/managed/format/RenameFormatStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,13 @@ public void executeFormatChange(JobDefinition jobDefinition, FormatChange format

if (runProcess(jobDefinition, rootPartitionList) && isPartitionCountCorrect(jobDefinition)) {
this.isComplete = formatUtil.renameExisitingTable(jobDefinition, clusterId, workerId,Lists.newArrayList());
if (this.isComplete) {
rootPartitionList.forEach(
partitionList ->
statsHelper.addAnalyzeStats(jobDefinition, partitionList)
);
}
// We are disabling collecting stats temporarily
// if (this.isComplete) {
// rootPartitionList.forEach(
// partitionList ->
// statsHelper.addAnalyzeStats(jobDefinition, partitionList)
// );
// }

}

Expand Down
3 changes: 2 additions & 1 deletion ...tLoader/src/main/java/org/finra/herd/metastore/managed/jobProcessor/HiveHqlGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,8 @@ private String getHqlFilePath(JobDefinition jd, List<String> partitions, boolean
addPartitionChanges(tableExists, jd, dataDdl, schemaHql);

//Stats
statsHelper.addAnalyzeStats(jd, partitions);
// Disabling for now
// statsHelper.addAnalyzeStats(jd, partitions);

// Create file
Path hqlFilePath = createHqlFile(jd);
Expand Down
2 changes: 1 addition & 1 deletion metastor/metastoreOperations/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<artifactId>metastore</artifactId>
<groupId>org.finra.herd-mdl.metastore</groupId>
<version>1.2.65</version>
<version>1.2.66</version>
</parent>
<modelVersion>4.0.0</modelVersion>

Expand Down
2 changes: 1 addition & 1 deletion metastor/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@

<artifactId>metastore</artifactId>
<groupId>org.finra.herd-mdl.metastore</groupId>
<version>1.2.65</version>
<version>1.2.66</version>

<packaging>pom</packaging>

Expand Down