Skip to content
This repository has been archived by the owner on Jan 12, 2021. It is now read-only.

Refactor ScreenshotUtils into better classes #88

Open
dpulitano opened this issue May 13, 2015 · 1 comment
Open

Refactor ScreenshotUtils into better classes #88

dpulitano opened this issue May 13, 2015 · 1 comment

Comments

@dpulitano
Copy link
Collaborator

I think the utils package shouldn't include the screenshot-taking functionality - the methods should be moved to the widget class if the screenshot is for the widget and should be in ExtWebDriver if the screenshot is for the entire browser window.

I propose ScreenshotUtils only has the code to perform comparisons and is renamed to ScreenshotComparator (This could be moved outside of ExtWebDriver at some point)

@dpulitano
Copy link
Collaborator Author

Pull request #87

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant