Wait For Condition Timer May Block Continuously

[mikeastarb]

https://github.com/FINRAOS/JTAF-ExtWebDriver/blob/master/src/main/java/org/finra/jtaf/ewd/timer/WaitForConditionTimer.java#L89

My team discovered today that, if the execute method of the callback blocks/hangs infinitely, this wait will also block/hang (waitForElementPresent ended up hanging on webdriver.findElement, which was waiting on IE to stop being busy). Our solution is to replace this logic with an ExecutorService and Future. This will still timeout if the passed in callable fails to return at all.

[MADiep]

You may want to look into the WebDriverWait class while you're at it. This is WebDriver's own implementation of performing explicit waits; it should make it a little easier to maintain if we can delegate that logic to the Selenium team.