Skip to content
This repository has been archived by the owner on Jan 12, 2021. It is now read-only.

PMD issues for class org.finra.jtaf.ewd.timer.WaitForConditionTimer #122

Open
mmlinford opened this issue May 2, 2016 · 0 comments
Open
Assignees

Comments

@mmlinford
Copy link
Collaborator

The following issues were found in org.finra.jtaf.ewd.timer.WaitForConditionTimer when running PMD:

[INFO] PMD Failure: org.finra.jtaf.ewd.timer.WaitForConditionTimer:31 Rule:ImmutableField Priority:3 Private field 'timerCallback' could be made final; it is only initialized in the declaration or constructor..
[INFO] PMD Failure: org.finra.jtaf.ewd.timer.WaitForConditionTimer:32 Rule:ImmutableField Priority:3 Private field 'locator' could be made final; it is only initialized in the declaration or constructor..
[INFO] PMD Failure: org.finra.jtaf.ewd.timer.WaitForConditionTimer:34 Rule:LoggerIsNotStaticFinal Priority:2 The Logger variable declaration does not contain the static and final modifiers.
[INFO] PMD Failure: org.finra.jtaf.ewd.timer.WaitForConditionTimer$ITimerCallback:65 Rule:SignatureDeclareThrowsException Priority:3 A method/constructor shouldnt explicitly throw java.lang.Exception.
[INFO] PMD Failure: org.finra.jtaf.ewd.timer.WaitForConditionTimer$ITimerCallback:65 Rule:UnusedModifier Priority:3 Avoid modifiers which are implied by the context.
[INFO] PMD Failure: org.finra.jtaf.ewd.timer.WaitForConditionTimer:89 Rule:IfStmtsMustUseBraces Priority:3 Avoid using if statements without curly braces.
[INFO] PMD Failure: org.finra.jtaf.ewd.timer.WaitForConditionTimer:93 Rule:PreserveStackTrace Priority:3 New exception is thrown in catch block, original stack trace may be lost.
[INFO] PMD Failure: org.finra.jtaf.ewd.timer.WaitForConditionTimer:94 Rule:AvoidCatchingGenericException Priority:3 Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant