Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review "Nested inherited must support element" warnings and root inclusions #15

Open
eyuasa opened this issue Aug 16, 2024 · 0 comments

Comments

@eyuasa
Copy link
Collaborator

eyuasa commented Aug 16, 2024

MADFSH heuristics for when to include nested must support elements are not very robust and require manual review. Warnings around these for the ig generation should be reviewed to determine:

  • Should the flagged nested element be included in the set of elements listed in the narrative?
  • Should the parent element be included in the set of elements listed in the narrative?
  • In general, elements that represent groupers (e.g. Encounter.hospitalization) or representation details (e.g., Patient.identifier.value) should not be included.

Additionally, cases where an element and its slices are present should be reviewed. Proposed rule of thumb here: if there are multiple relevant slices, include the slices but not the parent. If there is only one relevant slice include the parent but not the slice.

Update the MADFSH configuration to make explicit the choices based on the analysis, adjusting the list and removing the errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant