Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect/outdated damage values for DOT weapons #85

Open
Exotic-Retard opened this issue Jun 13, 2018 · 3 comments
Open

Incorrect/outdated damage values for DOT weapons #85

Exotic-Retard opened this issue Jun 13, 2018 · 3 comments
Labels

Comments

@Exotic-Retard
Copy link
Member

the dps calculation is correct! not everything is broken dont worry!

however, it looks like the damage display is using a different calculation which is outdated/wrong so the dps and damage dont add up, because the damage is wrong on weapons with damage over time:

see image for details: subs have the right dps and reload time, but the damage/projectile is done incorrectly.

@spooky spooky added the bug label Jun 14, 2018
@Exotic-Retard
Copy link
Member Author

just an update on this, since the bugfix for the beam calculations, which made the dps for the sera destroyer weapons correct, the damage for the sera destroyer also needs to be updated.

just to make sure, as of writing this, the dps on the sera destroyer is correct, but the damage/shot display is still incorrect.

@spooky
Copy link
Collaborator

spooky commented Jun 18, 2018

thx for the heads up!

@shalkya
Copy link
Member

shalkya commented Jul 18, 2020

Hello, nice to see you are working on the database again.
to have even improved dps calculation, you should take a look at this PR : FAForever/fa#3060
From my testing it has pretty much always accurate dps calculation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants