Feature/setting veto system fields #229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sheikah45
requested changes
Nov 29, 2024
Comment on lines
+51
to
+64
| vetoTokensPerPlayerInput.textProperty().addListener((observable, oldValue, newValue) -> { | ||
| try { | ||
| int value = Integer.parseInt(newValue); | ||
| if (value < 0 || value > 255) | ||
| throw new NumberFormatException("veto tokens per player must be between 0 and 255"); | ||
| if (!Objects.equals(property.get(), value)) { | ||
| property.set(value); | ||
| } | ||
| vetoTokensPerPlayerInput.setStyle(""); | ||
| } catch (NumberFormatException e) { | ||
| log.error(e.getMessage()); | ||
| vetoTokensPerPlayerInput.setStyle("-fx-background-color: rgb(255,100,100)"); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Use a TextFormatter instead of parsing and limiting the values and throwing an exception ourselves.
There was a problem hiding this comment.
like that?
vetoTokensPerPlayerInput.setTextFormatter(new TextFormatter<>(new IntegerStringConverter(), 0, change -> {
String newText = change.getControlNewText();
try {
int v = Integer.parseInt(newText);
if (v >= 0 && v <= 255) {
return change;
}
return null;
} catch (NumberFormatException e) {
log.error(e.getMessage());
return null;
}
}));
vetoTokensPerPlayerInput.textProperty().addListener((observable, oldValue, newValue) -> {
try {
int value = Integer.parseInt(newValue);
if (!Objects.equals(property.get(), value)) {
property.set(value);
}
} catch (NumberFormatException e) {
log.error(e.getMessage());
}
});
There was a problem hiding this comment.
or should i put property.set inside the formatter too
Comment on lines
+80
to
+98
| maxTokensPerMapInput.textProperty().addListener((observable, oldValue, newValue) -> { | ||
| try { | ||
| if (Objects.equals(newValue, "D")) { | ||
| property.set(0); | ||
| maxTokensPerMapInput.setStyle(""); | ||
| return; | ||
| } | ||
| int value = Integer.parseInt(newValue); | ||
| if (value < 1 || value > 255) | ||
| throw new NumberFormatException("max tokens per map must be between 1 and 255, or D (dynamic)"); | ||
| if (!Objects.equals(property.get(), value)) { | ||
| property.set(value); | ||
| } | ||
| maxTokensPerMapInput.setStyle(""); | ||
| } catch (NumberFormatException e) { | ||
| log.error(e.getMessage()); | ||
| maxTokensPerMapInput.setStyle("-fx-background-color: rgb(255,100,100)"); | ||
| } | ||
| }); |
Comment on lines
+120
to
+139
| minimumMapsAfterVetoInput.textProperty().addListener((observable, oldValue, newValue) -> { | ||
| try { | ||
| float value = Float.parseFloat(newValue); | ||
|
|
||
| if (value <= 0) { | ||
| throw new NumberFormatException("Minimum maps after veto must be greater than 0"); | ||
| } | ||
| String formattedValue = String.format(Locale.US, "%.2f", value); | ||
| if (!Objects.equals(minimumMapsAfterVetoInput.getText(), formattedValue)) { | ||
| minimumMapsAfterVetoInput.setText(formattedValue); | ||
| } | ||
| if (!Objects.equals(property.get(), value)) { | ||
| property.set(value); | ||
| } | ||
| minimumMapsAfterVetoInput.setStyle(""); | ||
| } catch (NumberFormatException e) { | ||
| log.error(e.getMessage()); | ||
| minimumMapsAfterVetoInput.setStyle("-fx-background-color: rgb(255,100,100)"); | ||
| } | ||
| }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #227
requires updated database and api with veto system fields updates
maxTokenPerMap: set "D" into the field as "Dynamic". I think this is more clear than 0.
Under the hood, D transforms to 0 anyway. Would be nice to have null instead of 0, but not possible currently due to patch request limitations in current api-service code.