Load the ICE servers from the new faf-icebreaker API

Author: Brutus5000

src/main/java/com/faforever/client/api/FafApiAccessor.java

@@ -157,6 +157,11 @@ public Mono<MeResult> getMe() {
         .doOnNext(object -> log.trace("Retrieved {} from /me with type MeResult", object));
   }
 
+  public Mono<IceSession> getIceSession(int gameId) {
+    return retrieveMonoWithErrorHandling(IceSession.class, apiWebClient.get().uri("/ice/session/game/" + gameId))
+        .doOnNext(object -> log.trace("Retrieved {} from /ice/session/game/{} with type MeResult", object, gameId));
+  }
+
   public Mono<Void> uploadFile(String endpoint, Path file, ByteCountListener listener,
                                java.util.Map<String, java.util.Map<String, ?>> params) {
     MultiValueMap<String, Object> multipartContent = createFileMultipart(file, listener);

src/main/java/com/faforever/client/api/IceSession.java

@@ -0,0 +1,11 @@
+package com.faforever.client.api;
+
+import com.faforever.commons.api.dto.CoturnServer;
+import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
+import org.jetbrains.annotations.NotNull;
+
+import java.util.List;
+
+@JsonIgnoreProperties(ignoreUnknown = true)
+public record IceSession(@NotNull String id, @NotNull List<CoturnServer> servers) {
+}

src/main/java/com/faforever/client/fa/relay/ice/CoturnService.java

@@ -1,6 +1,7 @@
 package com.faforever.client.fa.relay.ice;
 
 import com.faforever.client.api.FafApiAccessor;
+import com.faforever.client.api.IceSession;
 import com.faforever.client.mapstruct.IceServerMapper;
 import com.faforever.client.preferences.ForgedAlliancePrefs;
 import com.faforever.commons.api.dto.CoturnServer;
@@ -31,9 +32,9 @@ public CompletableFuture<List<CoturnServer>> getActiveCoturns() {
         .toFuture();
   }
 
-  public CompletableFuture<List<CoturnServer>> getSelectedCoturns() {
-    ElideNavigatorOnCollection<CoturnServer> navigator = ElideNavigator.of(CoturnServer.class).collection();
-    Flux<CoturnServer> coturnServerFlux = fafApiAccessor.getMany(navigator);
+  public CompletableFuture<List<CoturnServer>> getSelectedCoturns(int gameId) {
+    Flux<CoturnServer> coturnServerFlux = fafApiAccessor.getIceSession(gameId)
+        .flatMapIterable(IceSession::servers);
 
     Set<String> preferredCoturnIds = forgedAlliancePrefs.getPreferredCoturnIds();
 

src/main/java/com/faforever/client/game/GameService.java

@@ -665,7 +665,7 @@ private CompletableFuture<Void> startGame(GameParameters gameParameters) {
           localReplayPort = port;
           return iceAdapter.start(gameParameters.getUid());
         })
-        .thenCompose(adapterPort -> coturnService.getSelectedCoturns()
+        .thenCompose(adapterPort -> coturnService.getSelectedCoturns(uid)
             .thenAccept(iceAdapter::setIceServers)
             .thenApply(aVoid -> adapterPort))
         .thenApply(adapterPort -> {

src/main/java/com/faforever/client/mapstruct/IceServerMapper.java

@@ -14,7 +14,6 @@ public Map<String, Object> map(CoturnServer coturnServer) {
     return Map.of(
         "urls", coturnServer.getUrls().stream().map(URI::toString).toList(),
         "credential", coturnServer.getCredential(),
-        "credentialType", coturnServer.getCredentialType(),
         "username", coturnServer.getUsername()
     );
   }

src/test/java/com/faforever/client/fa/relay/ice/CoturnServiceTest.java

@@ -1,6 +1,7 @@
 package com.faforever.client.fa.relay.ice;
 
 import com.faforever.client.api.FafApiAccessor;
+import com.faforever.client.api.IceSession;
 import com.faforever.client.mapstruct.IceServerMapper;
 import com.faforever.client.mapstruct.MapperSetup;
 import com.faforever.client.preferences.ForgedAlliancePrefs;
@@ -14,11 +15,13 @@
 import org.mockito.Mock;
 import org.mockito.Spy;
 import reactor.core.publisher.Flux;
+import reactor.core.publisher.Mono;
 
 import java.util.List;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.anyInt;
 import static org.mockito.ArgumentMatchers.argThat;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
@@ -53,26 +56,26 @@ public void TestGetSelectedCoturnsNoActiveSelected() {
 
     CoturnServer otherServer = new CoturnServer();
     otherServer.setId("0");
-    when(fafApiAccessor.getMany(any())).thenReturn(Flux.just(otherServer));
+    when(fafApiAccessor.getIceSession(anyInt())).thenReturn(Mono.just(new IceSession("someSessionId", List.of(otherServer))));
 
-    List<CoturnServer> servers = instance.getSelectedCoturns().join();
+    List<CoturnServer> servers = instance.getSelectedCoturns(123).join();
 
     assertEquals(1, servers.size());
     assertEquals("0", servers.get(0).getId());
-    verify(fafApiAccessor).getMany(argThat(ElideMatchers.hasDtoClass(CoturnServer.class)));
+    verify(fafApiAccessor).getIceSession(123);
   }
 
   @Test
   public void testGetSelectedCoturnsNoneSelected() {
     CoturnServer otherServer = new CoturnServer();
     otherServer.setId("0");
-    when(fafApiAccessor.getMany(any())).thenReturn(Flux.just(otherServer));
+    when(fafApiAccessor.getIceSession(anyInt())).thenReturn(Mono.just(new IceSession("someSessionId", List.of(otherServer))));
 
-    List<CoturnServer> servers = instance.getSelectedCoturns().join();
+    List<CoturnServer> servers = instance.getSelectedCoturns(123).join();
 
     assertEquals(1, servers.size());
     assertEquals("0", servers.get(0).getId());
-    verify(fafApiAccessor).getMany(argThat(ElideMatchers.hasDtoClass(CoturnServer.class)));
+    verify(fafApiAccessor).getIceSession(123);
   }
 
   @Test
@@ -83,12 +86,12 @@ public void testGetSelectedCoturnsActiveSelected() {
     otherServer.setId("0");
     CoturnServer selectedServer = new CoturnServer();
     otherServer.setId("1");
-    when(fafApiAccessor.getMany(any())).thenReturn(Flux.just(otherServer, selectedServer));
+    when(fafApiAccessor.getIceSession(anyInt())).thenReturn(Mono.just(new IceSession("someSessionId", List.of(otherServer, selectedServer))));
 
-    List<CoturnServer> servers = instance.getSelectedCoturns().join();
+    List<CoturnServer> servers = instance.getSelectedCoturns(123).join();
 
     assertEquals(1, servers.size());
     assertEquals("1", servers.get(0).getId());
-    verify(fafApiAccessor).getMany(argThat(ElideMatchers.hasDtoClass(CoturnServer.class)));
+    verify(fafApiAccessor).getIceSession(123);
   }
 }

src/test/java/com/faforever/client/game/GameServiceTest.java

@@ -186,7 +186,7 @@ public void setUp() throws Exception {
 
     when(fxApplicationThreadExecutor.asScheduler()).thenReturn(Schedulers.immediate());
     when(fafServerAccessor.getEvents(GameInfo.class)).thenReturn(testPublisher.flux());
-    when(coturnService.getSelectedCoturns()).thenReturn(completedFuture(List.of()));
+    when(coturnService.getSelectedCoturns(anyInt())).thenReturn(completedFuture(List.of()));
     when(preferencesService.isValidGamePath()).thenReturn(true);
     when(fafServerAccessor.connectionStateProperty()).thenReturn(new SimpleObjectProperty<>());
     when(replayServer.start(anyInt(), any())).thenReturn(completedFuture(LOCAL_REPLAY_PORT));