Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work on haxe 3.2.1 #2

Open
kevinresol opened this issue May 22, 2016 · 4 comments
Open

Doesn't work on haxe 3.2.1 #2

kevinresol opened this issue May 22, 2016 · 4 comments

Comments

@kevinresol
Copy link
Member

Fails with src/js/extern/Extern.hx:10: characters 15-21 : Unexpected extern

The only reason I can think of is that the keyword extern is not allowed as package name...

@fantoine
Copy link
Contributor

It seems that this keyword has been allowed in haxe 3.3. Since I work with nightly builds I didn't noticed that.
Maybe it should be renamed to something like externkit to keep the compatibility.

@kevinresol
Copy link
Member Author

kevinresol commented May 24, 2016

Agreed. There are other problems as well.

I suggest putting the whole extern kit libraries under externkit, like:
package externkit.js;
package externkit.js.redis;

@fantoine
Copy link
Contributor

I also know about these issues.
I used @:noPackageRestrict to avoid the 'forbidden js package' it's a 'private' meta.

In a first hand, changing all packages should solve lots of issues.
But in an other hand, externkit looks very long to type to me and externs look too much "integrated" in a library.
Maybe we could just get rid of the js namespace, but we may get conflicts with some other libraries.

Some ideas:

import externkit.js.aws.cognito.Cognito;
// or
import ekt.js.aws.cognito.Cognito;
// or
import aws.js.cognito.Cognito;
// or
import externkit.aws.cognito.Cognito;
// or
import extkit.aws.cognito.Cognito;
// or
import aws.cognito.Cognito;

Personally, I prefer the last case. What's your opinion?

@kevinresol
Copy link
Member Author

I prefer fullnames (unless really common terms like aws), so ekt, extkit are ruled out
I like the the last one but I would vote for the first one because it is much more explicity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants