Skip to content

fix: unable to move per diem to a new report after changing workspace #91030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daledah wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −5
Open

fix: unable to move per diem to a new report after changing workspace #91030

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7e8d2a
fix: unable to move per diem to a new report after changing workspace
daledah May 19, 2026
eb43469
Merge branch 'main' into fix/81307
daledah May 20, 2026
b91ca24
Merge remote-tracking branch 'upstream/main' into fix/81307
daledah May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/pages/iou/request/step/IOURequestEditReport.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,6 @@ function IOURequestEditReport({route}: IOURequestEditReportProps) {
() => getPersonalDetailsForAccountID(selectedReport?.ownerAccountID, personalDetails) as PersonalDetails,
[personalDetails, selectedReport?.ownerAccountID],
);
const selectedReportPolicy = allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${selectedReport?.policyID}`];

const hasPerDiemTransactions = useHasPerDiemTransactions(transactionIDs);

// When moving an expense that belongs to another user, or when the selection includes per diem
Expand Down Expand Up @@ -126,12 +124,12 @@ function IOURequestEditReport({route}: IOURequestEditReportProps) {
return;
}

const policyForNewReport = hasPerDiemTransactions ? selectedReportPolicy : policyForMovingExpenses;
const optimisticReport = createNewReport(ownerPersonalDetails, hasViolations, isASAPSubmitBetaEnabled, policyForNewReport, betas, false, shouldDismissEmptyReportsConfirmation);
const optimisticReport = createNewReport(ownerPersonalDetails, hasViolations, isASAPSubmitBetaEnabled, policyForMovingExpenses, betas, false, shouldDismissEmptyReportsConfirmation);
selectReport(
{
value: optimisticReport.reportID,
keyForList: optimisticReport.reportID,
policyID: optimisticReport.policyID,
},
optimisticReport,
);
Expand All @@ -145,7 +143,7 @@ function IOURequestEditReport({route}: IOURequestEditReportProps) {
});

const createReport = () => {
const restrictionPolicy = hasPerDiemTransactions ? selectedReportPolicy : policyForMovingExpenses;
const restrictionPolicy = policyForMovingExpenses;
if (restrictionPolicy && shouldRestrictUserBillableActions(restrictionPolicy, ownerBillingGracePeriodEnd, userBillingGracePeriodEnds, amountOwed, session?.accountID)) {
Navigation.navigate(ROUTES.RESTRICTED_ACTION.getRoute(restrictionPolicy.id));
return;
Expand Down
Loading