[DB MileageRate] Replace workspace mileage rate list with table UI#90920
[DB MileageRate] Replace workspace mileage rate list with table UI#90920Krishna2323 wants to merge 7 commits into
Conversation
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bcdd150bdd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| {canSelectMultiple && ( | ||
| <View style={[styles.mr3]}> | ||
| <Checkbox | ||
| isChecked={isSelected} | ||
| onPress={onToggle} | ||
| accessibilityLabel={rate.name ?? ''} | ||
| disabled={isDeleting} | ||
| /> |
There was a problem hiding this comment.
Restore mobile selection entry point
When the date-bound mileage rate table is shown on narrow screens, canSelectMultiple is false until mobile selection mode is already enabled, and this row only renders the checkbox inside that gate while normal row presses navigate to details. The previous SelectionListWithModal path enabled selection mode via long-press (turnOnSelectionModeOnLongPress), but the new table row does not provide any equivalent onLongPress/selection-mode trigger, so mobile users in this beta cannot select rates and therefore cannot reach the bulk delete/enable/disable actions.
Useful? React with 👍 / 👎.
| compareItems={compareItems} | ||
| isItemInSearch={isItemInSearch} |
There was a problem hiding this comment.
Render the table search control
The new beta table passes isItemInSearch, but no <Table.SearchBar /> is rendered anywhere in the table children, while the old list displayed a search bar once the rate count exceeded CONST.SEARCH_ITEM_LIMIT. As a result, workspaces with many date-bound mileage rates lose the ability to search/filter the rate list in this UI despite the predicate being wired up.
Useful? React with 👍 / 👎.
… distance rates table Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…ence Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Explanation of Change
Fixed Issues
$ #89831
PROPOSAL:
Tests
Beta: Table UI renders correctly
dateBoundMileageRatebetaBeta: Status labels are correct
Beta: Sorting works
Beta: Checkbox selection and bulk actions
Beta: Narrow layout
Offline tests
QA Steps
Same as tests
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari