[$250] Odometer – Re-add Rotate and Crop buttons for stitched odometer receipt images

[melvin-bot]

Problem
The Rotate and Crop buttons are hidden for stitched odometer receipt images, so admins/users cannot rotate or crop them. OldDot (Classic) allows both Rotate and Crop on these attachments, and we want to support the same in New Expensify.

Root cause
When the stitched-odometer work landed, the original intent was to hide only the "replace image" button for stitched images, but the change unintentionally hid the rotate and crop buttons as well.

Relevant keywords in the codebase:

• shouldShowRotateAndCropReceiptButton is derived from shouldShowReplaceReceiptButton
• shouldShowReplaceReceiptButton includes && !isStitchedOdometerReceipt

Expected behavior
Show the Rotate and Crop buttons for stitched odometer receipt images (while still hiding the "replace image" button, as intended).

Reported in Slack.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022087790306188043766
• Upwork Job ID: 2087790306188043766
• Last Price Increase: 2026-08-13

[DylanDylann]

@MelvinBot Could you propose a fix?

[MelvinBot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Rotate and Crop buttons are hidden for stitched odometer receipt images, even though only the "replace image" button was meant to be hidden for them. OldDot allows rotate/crop on these attachments and NewDot should too.

What is the root cause of that problem?

shouldShowRotateAndCropReceiptButton is derived from shouldShowReplaceReceiptButton, which carries the stitched-odometer exclusion. So the exclusion meant only for the replace button also suppresses rotate/crop.

• TransactionReceiptModalContent.tsx:166 — shouldShowReplaceReceiptButton = ((canEditReceipt && !readonly) || isDraftTransaction) && !transaction?.receipt?.isTestDriveReceipt && !isStitchedOdometerReceipt
• TransactionReceiptModalContent.tsx:361-370 — shouldShowRotateAndCropReceiptButton starts with shouldShowReplaceReceiptButton && …, inheriting !isStitchedOdometerReceipt.

What changes do you think we should make in order to solve the problem?

Decouple the two flags by extracting the shared editability precondition, then apply the stitched-odometer exclusion only to the replace button.

In TransactionReceiptModalContent.tsx:166:

const canEditReceiptButtons = ((canEditReceipt && !readonly) || isDraftTransaction) && !transaction?.receipt?.isTestDriveReceipt;
const shouldShowReplaceReceiptButton = canEditReceiptButtons && !isStitchedOdometerReceipt;

Then update the shouldShowRotateAndCropReceiptButton memo (:361-370) to depend on canEditReceiptButtons instead of shouldShowReplaceReceiptButton (updating the dependency array accordingly). Its existing hasReceiptSource(transaction) || (isOdometerImage && hasOdometerImageSource(...)), !isEReceipt, and isImage guards continue to gate correctly.

This keeps the replace button hidden for stitched odometer receipts while restoring rotate/crop. The container-visibility check at :528 already keys off shouldShowRotateAndCropReceiptButton, so the buttons will render once the flag is true.

Why this is minimal and safe

• canEditReceiptButtons folds in the isTestDriveReceipt check the rotate/crop memo already performed redundantly, so no behavior changes for test-drive receipts.
• Only stitched odometer receipts (isOdometerDistanceRequest(transaction) && !imageType) are affected — every other receipt path evaluates canEditReceiptButtons identically to today's shouldShowReplaceReceiptButton.

What alternative solutions did you explore? (Optional)

Simply dropping !isStitchedOdometerReceipt from shouldShowReplaceReceiptButton — rejected because it would also re-show the replace button, which we intentionally keep hidden.

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/98513#issuecomment-5276447472) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.

[DylanDylann]

@MelvinBot Implement this

[MelvinBot]

🤖 Draft PR created: #98540

What it does: Extracts the shared editability precondition into canEditReceiptButtons and applies the !isStitchedOdometerReceipt exclusion only to the replace button. shouldShowRotateAndCropReceiptButton now depends on canEditReceiptButtons instead of shouldShowReplaceReceiptButton, so Rotate and Crop are restored for stitched odometer receipts while the "replace image" button stays hidden as intended.

Checks run locally (all passing): lint-changed, typecheck (tsgo), and React Compiler compliance. The odometer-specific UI flow needs a stitched odometer receipt to exercise, so I left detailed manual test steps in the PR for QA to verify — please review them and mark the PR as "Ready for review" once you're happy with it.