Android - Expensify Card - Workflows page is shown briefly before navigating to More features

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.

---

Version Number: 9.4.53-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #96567
Email or phone of affected tester (no customers): applausetester+ssndjois2jd1@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Workspace Settings

Action Performed:

Precondition:

• Set up workspace with Expensify Card feature.
• Disable Workflows in workspace settings > More features.

1. Launch Expensify app.
2. Go to workspace settings > Expensify Card.
3. Tap Issue card.
4. Proceed to Choose a limit type.
5. Tap Enable approvals.

Expected Result:

Workflows page will not appear before navigating to More features.

Actual Result:

Workflows page is shown briefly before navigating to More features.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7232118_1786569477592.Screen_Recording_20260813_051529_Expensify.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7232118

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/e1497f5e35d73837b8b681df4146c2991eafde97d0942107aca804efb185a3f1

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #96567

[melvin-bot]

@youssef-lr @truph01 you have been assigned to this deploy blocker because you reviewed the offending PR: #96567

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #96567 - "Show Smart Limit card option disabled when approvals are optional" by @MelvinBot (High confidence)
Related Issues: #94072 (the issue this PR implemented)

Recommendation: ROLL FORWARD

The PR implements an approved proposal (the disabled Smart Limit option with an "Enable approvals" link), so reverting would throw away the whole feature for a minor cosmetic flash. The fix is a one-line change to the link destination, which is much simpler and safer than a revert.

Assigned: @youssef-lr (approving reviewer + merger) and @truph01 (approving reviewer) from PR #96567 — already assigned to this issue
Labels: No changes. DeployBlockerCash is kept (an App PR caused this, and it is not reproducible in production).

📋 Detailed Analysis

Evidence

• PR Show Smart Limit card option disabled when approvals are optional #96567 introduced the new disabled Smart Limit row shown when the workspace uses Optional approvals. Its description contains an inline "Enable approvals" link (smartLimitDisabledDescription) added by this PR — this is exactly the element the tester taps in the repro.
• The link target is built as workspaceWorkflowsPageURL = ${environmentURL}/${ROUTES.WORKSPACE_WORKFLOWS.getRoute(policyID)} and points unconditionally to the Workflows page.
• The bug reproduces only on staging (v9.4.53-0) and is a brand-new feature not in production — consistent with this PR being on the current StagingDeployCash checklist (Deploy Checklist: New Expensify 2026-08-12 #98463).

Verification

Affected files (both added the exact same pattern in this PR):

• Issue-new-card flow: src/pages/workspace/expensifyCard/issueNew/LimitTypeStep.tsx
  • Link URL built at L105
  • Rendered into the disabled row at L114-L115
• Edit-existing-card flow: src/pages/workspace/expensifyCard/DynamicExpensifyCardLimitTypePage.tsx
  • Link URL built at L173
  • Rendered at L181

The Workflows page is feature-gated. It is wrapped in AccessOrNotFoundWrapper with featureName={CONST.POLICY.MORE_FEATURES.ARE_WORKFLOWS_ENABLED} at WorkspaceWorkflowsPage.tsx#L1125-L1127. When the Workflows feature is disabled, that wrapper redirects after mount inside a useEffect, calling Navigation.goBack(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID)) at AccessOrNotFoundWrapper.tsx#L230-L241.

Root Cause

In the repro the workspace has the Workflows feature disabled in More features, so areApprovalsConfigured is false and the disabled Smart Limit row (with the "Enable approvals" link) is shown. Tapping the link navigates to ROUTES.WORKSPACE_WORKFLOWS. Because the Workflows feature is off, the destination page mounts first and only then does AccessOrNotFoundWrapper's post-mount useEffect redirect to More features — producing the visible "flash" of the Workflows page before landing on More features.

Recommended Fix

Make the link destination conditional on whether the Workflows feature is actually enabled, rather than always pointing to the Workflows route. When the feature is disabled, route straight to ROUTES.WORKSPACE_MORE_FEATURES so the Workflows page is never mounted (no flash); when it is enabled, keep pointing to ROUTES.WORKSPACE_WORKFLOWS. Apply the same change in both LimitTypeStep.tsx (L105) and DynamicExpensifyCardLimitTypePage.tsx (L173), e.g. gate on isPolicyFeatureEnabled(policy, CONST.POLICY.MORE_FEATURES.ARE_WORKFLOWS_ENABLED).