Expense - Keep selected option is shown when one of the duplicate expenses is paid

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.79-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #89587
Email or phone of affected tester (no customers): sdsdjoijdoisnjodis@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create an expense.
4. Click Submit, Approve and Mark as paid.
5. Create another expense with the same amount from Step 3.
6. Open the report.
7. Click Review duplicates.
8. Select the paid expense > click Keep selected > Confirm.

Expected Result:

Keep selected option should be hidden when one of the duplicates is paid expense (production).

Actual Result:

Keep selected option is shown when one of the duplicates is paid expense.
After keeping the paid expense, the unpaid expense is not removed. Review duplicates process fails.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7160181_1779408460043.08.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7160181

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/b7908ff9cf294228c4e8a505cc158aac640e83134f7faa47c04cca5064b05696

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #89587

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

What is the root cause of that problem?

PR #89587 redesigned the "Review duplicates" screen, replacing per-item TransactionPreviewContent cards (each with its own "Keep this one" button) with compact TransactionItemRow rows and a single global "Keep selected" button in the footer.

The old per-item button had guards that hid it when a transaction was settled, approved, or a card transaction (TransactionPreviewContent.tsx:436):

isReviewDuplicateTransactionPage && !isIOUSettled && !isApproved && !isCardTransaction && areThereDuplicates

The new global "Keep selected" button (Review.tsx:261-267) only checks isDisabled={!selectedTransaction || !selectedTransactionReport} — the settled/approved guards were not carried over.

The variable hasSettledOrApprovedTransaction is already computed at line 86 and used for the informational warning text, but is never used to control button visibility.

What changes do you think we should make in order to solve the problem?

In Review.tsx, hide the "Keep selected" button when hasSettledOrApprovedTransaction is true — either by conditionally rendering it or by adding hasSettledOrApprovedTransaction to the isDisabled condition. Hiding it entirely (not rendering) matches the old behavior where the per-item "Keep this one" button simply didn't appear for settled/approved transactions.

What alternative solutions did you explore? (Optional)

An alternative is to disable radio-button selection for settled/approved transactions in DuplicateTransactionItem.tsx, but this is more complex and doesn't match the original product behavior where the entire "keep" action was hidden — not just individual selections.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.