Home - Your spend section does not update after updating expense offline

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.79-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #89899
Email or phone of affected tester (no customers): jnosdijosidjnodjsioj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create an expense.
4. Click Submit.
5. Go to Home.
6. Go to Inbox.
7. Go offline.
8. Open the expense.
9. Edit the amount and save it.
10. Go to Home.

Expected Result:

Your spend section will update after updating expense offline.

Actual Result:

Your spend section does not update after updating expense offline.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7160112_1779401299487.4.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7160112

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/3fa52c2505b492a2c923cddfcbed81385177e497c9c6fe61495ad639c8c166d9

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #89899

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

What is the root cause of that problem?

The "Your spend" section reads its totals from server-computed aggregates in ONYXKEYS.COLLECTION.SNAPSHOT (useYourSpendData.ts:94-96), not from raw transaction Onyx data. These snapshots are refreshed via API calls that are skipped when offline (useYourSpendData.ts:269-270: if (isOffline) { return; }).

When a transaction amount is edited offline, updateMoneyRequestAmountAndCurrency updates ONYXKEYS.COLLECTION.TRANSACTION and ONYXKEYS.COLLECTION.REPORT optimistically, but never updates the snapshot.search aggregate fields (total, currency, count) that "Your spend" depends on. The snapshot update in UpdateMoneyRequest.ts:100-141 only touches snapshot.data (the individual transaction record) and only when a hash is provided — which doesn't happen when editing from the expense detail screen, and would be the wrong hash even if it did.

What changes do you think we should make in order to solve the problem?

When a transaction that matches the "Your spend" query filters is edited offline, the snapshot's search.total aggregate should be optimistically updated with the amount delta. Specifically:

1. In useYourSpendData.ts, subscribe to the relevant ONYXKEYS.COLLECTION.TRANSACTION entries (those matching the "awaiting approval" / "repaid last 30 days" filters) and recompute totals client-side when a transaction amount changes while offline. This keeps the displayed totals in sync with the optimistically-updated transaction data without requiring a network call.

2. Alternatively, extend the optimistic update logic in getUpdateMoneyRequestParams (in UpdateMoneyRequest.ts) to also compute and write the amount delta to the Your spend snapshot's search.total field, using the query hashes from queries.ts. This approach keeps the fix contained in the action layer.

What alternative solutions did you explore? (Optional)

• Re-firing searches on Home focus even when offline: Not viable because search() requires network — the API call would fail.
• Invalidating the cached totals: This would cause the section to show a loading state or disappear while offline, which is worse UX than showing stale data.

Investigation details

Data flow:

1. Home page focuses → useYourSpendData hook runs
2. queries.ts builds search queries (e.g., type:expense status:outstanding from:accountID reimbursable:yes)
3. Each query is hashed, and useOnyx subscribes to SNAPSHOT+hash
4. On focus + online: fireSearches() calls the search API with shouldCalculateTotals:true
5. API returns server-computed aggregates stored at snapshot.search.total
6. Bug: offline edit updates TRANSACTION Onyx key but snapshot.search.total stays stale, and fireSearches() is a no-op while offline

Three layers of failure:

1. fireSearches() bails immediately when offline (line 269)
2. getSearchSnapshotUpdates() only updates snapshot.data, never snapshot.search aggregates (lines 100-141)
3. No hash is passed when editing from non-search contexts, so even snapshot.data isn't updated (line 1562-1577)

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.