[$250] Workflow - Click Payer when add bank process still not finish will redirect to Not here page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.60-17
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: N/A
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 11 / Chrome, Android 13 / Xiaomi Poco F5, iOS 15.8.3 / iPhone 7 Plus
App Component: Workspace Settings

Action Performed:

Precondition:

• At least have a workspace
• Have a process of adding a bank account, but exit in the middle of it

1. Login to ND
2. Navigate to Workspace > Workflows
3. Click on the Payer button

Expected Result:

The Payer button should be disabled or hidden when the process of adding a bank account is still not finished

Actual Result:

Click the Payer button when add bank process still not finish will redirect to the Not here page

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7133154_1776535609390.88022_-_Workflow_-_Click_Payer_when_add_bank_process_still_not_finish_will_redirect_to_Not_here_page.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022054386044800080331
• Upwork Job ID: 2054386044800080331
• Last Price Increase: 2026-05-13

[MelvinBot]

Proposal

What is the root cause of that problem?

There is a condition mismatch between the Payer button visibility on the Workflows page and the NotFound guard on the Payer page.

The Workflows page shows the Payer button when reimbursementChoice !== REIMBURSEMENT_NO (WorkspaceWorkflowsPage.tsx:304), which allows REIMBURSEMENT_MANUAL and undefined values through.

But the Payer page shows FullPageNotFoundView when reimbursementChoice !== REIMBURSEMENT_YES (WorkspaceWorkflowsPayerPage.tsx:250-251), which is strictly narrower.

When a user starts bank account setup but exits midway, a partial bank account entry exists in BANK_ACCOUNT_LIST with additionalData.policyID set to the workspace. This makes bankAccountConnectedToWorkspace truthy, so shouldShowBankAccount is true and the Payer button appears. But if reimbursementChoice is anything other than REIMBURSEMENT_YES (e.g. REIMBURSEMENT_MANUAL for non-USD workspaces, or undefined), clicking the button leads to the "Not here" page.

What changes do you think we should make in order to solve the problem?

Align the two conditions. On the Payer page (WorkspaceWorkflowsPayerPage.tsx:251), change the blocking condition from reimbursementChoice !== REIMBURSEMENT_YES to reimbursementChoice === REIMBURSEMENT_NO (or !reimbursementChoice), so that it matches the Workflows page gate.

Alternatively, tighten the Workflows page condition at WorkspaceWorkflowsPage.tsx:304 to only show the Payer button when reimbursementChoice === REIMBURSEMENT_YES, so the button never appears if the Payer page would block it.

The simpler and safer fix is the second approach — tighten the Workflows page to use === REIMBURSEMENT_YES instead of !== REIMBURSEMENT_NO, since the Payer page is only meaningful when direct reimbursement is enabled.

What alternative solutions did you explore? (Optional)

• Disabling the Payer button (instead of hiding it) when bank account setup is incomplete — but this would leave a confusing disabled button with no clear explanation.
• Adding a loading/redirect guard on the Payer page to send users back when the state is invalid — but hiding the button entirely is cleaner UX.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022054386044800080331

[wildan-m]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On a workspace where the admin has an in-progress business bank account setup (state is not yet OPEN or LOCKED), opening Workspace > Workflows still renders the "Payer" row under Make/track payments. Tapping it navigates to the Payer page, which refuses to render and shows the full-page "Not here" blocking screen instead of a usable selection UI.

What is the root cause of that problem?

The Payer row on the Workflows page and the blocking guard on the Payer page disagree about when a Payer can be selected.

The Payer row renders whenever shouldShowBankAccount is true. shouldShowBankAccount becomes true as soon as any bank account is linked to the workspace — even one in an incomplete state like SETUP, VERIFYING, or PENDING — as long as reimbursementChoice is anything except REIMBURSEMENT_NO:

App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

Line 268 in 03023c1

const shouldShowBankAccount = (!!isBankAccountFullySetup || !!bankAccountConnectedToWorkspace) && policy?.reimbursementChoice !== CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_NO;

The Payer row itself is gated only by that same flag:

App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

Lines 533 to 553 in 03023c1

	{shouldShowBankAccount && (
	<OfflineWithFeedback
	pendingAction={policy?.pendingFields?.reimburser}
	shouldDisableOpacity={isOffline && !!policy?.pendingFields?.reimbursementChoice && !!policy?.pendingFields?.reimburser}
	errors={getLatestErrorField(policy ?? {}, CONST.POLICY.COLLECTION_KEYS.REIMBURSER)}
	onClose={() => clearPolicyErrorField(policy?.id, CONST.POLICY.COLLECTION_KEYS.REIMBURSER)}
	errorRowStyles={[styles.ml7]}
	>
	<MenuItemWithTopDescription
	title={displayNameForAuthorizedPayer ?? ''}
	titleStyle={styles.textNormalThemeText}
	descriptionTextStyle={styles.textLabelSupportingNormal}
	description={translate('workflowsPayerPage.payer')}
	onPress={() => Navigation.navigate(ROUTES.WORKSPACE_WORKFLOWS_PAYER.getRoute(route.params.policyID))}
	sentryLabel={CONST.SENTRY_LABEL.WORKSPACE.WORKFLOWS.AUTHORIZED_PAYER}
	shouldShowRightIcon
	wrapperStyle={[styles.sectionMenuItemTopDescription, styles.mt3, styles.mbn3]}
	brickRoadIndicator={hasReimburserError ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined}
	/>
	</OfflineWithFeedback>
	)}

But WorkspaceWorkflowsPayerPage blocks with FullPageNotFoundView whenever policy?.reimbursementChoice !== REIMBURSEMENT_YES (alongside empty-policy and pending-delete checks):

App/src/pages/workspace/workflows/WorkspaceWorkflowsPayerPage.tsx

Lines 250 to 273 in 03023c1

	const shouldShowBlockingPage =
	(isEmptyObject(policy) && !isLoadingReportData) || isPendingDeletePolicy(policy) || policy?.reimbursementChoice !== CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_YES;
	const totalNumberOfEmployeesEitherOwnerOrAdmin = Object.entries(policy?.employeeList ?? {}).filter(([email, policyEmployee]) => {
	const isOwner = policy?.owner === email;
	const isAdmin = policyEmployee.role === CONST.POLICY.ROLE.ADMIN;
	return !isDeletedPolicyEmployee(policyEmployee) && (isOwner || isAdmin);
	});
	const shouldShowSearchInput = totalNumberOfEmployeesEitherOwnerOrAdmin.length >= CONST.STANDARD_LIST_ITEM_LIMIT;
	return (
	<AccessOrNotFoundWrapper
	accessVariants={[CONST.POLICY.ACCESS_VARIANTS.ADMIN, CONST.POLICY.ACCESS_VARIANTS.PAID]}
	policyID={route.params.policyID}
	featureName={CONST.POLICY.MORE_FEATURES.ARE_WORKFLOWS_ENABLED}
	>
	<FullPageNotFoundView
	shouldShow={shouldShowBlockingPage}
	shouldForceFullScreen
	subtitleKey={isEmptyObject(policy) ? undefined : 'workspace.common.notAuthorized'}
	onBackButtonPress={goBackFromInvalidPolicy}
	onLinkPress={goBackFromInvalidPolicy}
	>

When a bank is still mid-setup, reimbursementChoice can be REIMBURSEMENT_MANUAL (non-USD workspace with a partial achAccount) or be missing entirely, so the guard on the Payer page trips and the "Not here" screen renders. Meanwhile the Workflows page is happy to surface the link because it is not checking whether the bank has actually finished setup. Same is true even on the happy path of REIMBURSEMENT_YES — the Payer flow has no fully-set-up bank account to share, so the row is not actionable regardless of which guard fires.

Semantically the bank section already knows about this state: it computes isBankAccountFullySetup = policy?.achAccount && (state === OPEN || state === LOCKED) and isAccountInSetupState = isBankAccountPartiallySetup(state), and uses those to show the "Action required" badge on the bank row itself:

App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

Lines 257 to 266 in 03023c1

	const isBankAccountFullySetup = policy?.achAccount && (policy?.achAccount.state === CONST.BANK_ACCOUNT.STATE.OPEN || policy?.achAccount.state === CONST.BANK_ACCOUNT.STATE.LOCKED);
	const bankAccountConnectedToWorkspace = Object.values(bankAccountList ?? {}).find((bankAccount) => bankAccount?.accountData?.additionalData?.policyID === policy?.id);
	const bankName = isBankAccountFullySetup ? (policy?.achAccount?.bankName ?? '') : (bankAccountConnectedToWorkspace?.accountData?.additionalData?.bankName ?? '');
	const addressName = isBankAccountFullySetup ? (policy?.achAccount?.addressName ?? '') : (bankAccountConnectedToWorkspace?.accountData?.addressName ?? '');
	const accountData = isBankAccountFullySetup ? policy?.achAccount : bankAccountConnectedToWorkspace?.accountData;
	const bankTitle = addressName.includes(CONST.MASKED_PAN_PREFIX) ? bankName : addressName;
	const bankAccountID = isBankAccountFullySetup ? policy?.achAccount?.bankAccountID : bankAccountConnectedToWorkspace?.methodID;
	const state = isBankAccountFullySetup ? (policy?.achAccount?.state ?? '') : (bankAccountConnectedToWorkspace?.accountData?.state ?? '');
	const isAccountInSetupState = isBankAccountPartiallySetup(state);
	const isBusinessBankAccountLocked = state === CONST.BANK_ACCOUNT.STATE.LOCKED;

The Payer row simply is not consulting that signal.

What changes do you think we should make in order to solve the problem?

Keep shouldShowBankAccount as-is so the bank-account row continues to render during setup (the "Action required" badge is what invites the admin back into the flow), but additionally require isBankAccountFullySetup before rendering the Payer row in WorkspaceWorkflowsPage. Change the gate at line 533 from {shouldShowBankAccount && ( to {shouldShowBankAccount && !!isBankAccountFullySetup && (.

This matches the Payer concept: a Payer is the admin authorized to reimburse from a connected bank, so there is nothing to choose until the bank reaches OPEN or LOCKED. Hiding the row (rather than disabling it) avoids the dead-end navigation to the "Not here" page described in the report, and aligns the Workflows page with the guard already in place on WorkspaceWorkflowsPayerPage. Once the admin finishes the bank setup via the "Action required" row above, the Payer row reappears automatically on the same screen.

Compare branch: https://github.com/Expensify/App/compare/main...wildan-m:App:wildan/88263-payer-partial-bank-setup?expand=1

What alternative solutions did you explore? (Optional)

Rendering the Payer row as disabled with a tooltip explaining that the bank must finish setup was considered, but a disabled row still leaves an ambiguous control on the screen next to the actionable "Action required" bank row, and disabling a MenuItemWithTopDescription adds a isOffline || !isPolicyAdmin-style branch that has to stay in sync with the Payer page's guard. Hiding the row keeps the screen focused on the one remaining action (finish the bank setup) and needs only the extra boolean on the existing conditional.