Expense - "Pay with personal account" instead of "Pay with wallet" is shown

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.58-7
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #84657
Email or phone of affected tester (no customers): dayis32673@nyspring.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• User has personal bank account.
• User has received two IOU expenses in USD currency from another user.

1. Go to staging.new.expensify.com
2. Open IOU report with two expenses in USD currency from another user.
3. Click Pay dropdown button.
   → Pay with wallet is shown.
4. Bulk select both expenses.
5. Click More > Pay.

Expected Result:

"Pay with wallet" option will be shown.

Actual Result:

"Pay with personal account" instead of "Pay with wallet" is shown.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #84657

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #85796 - "Add selection mode Submit/Approve/Pay actions for mobile layout." by @Krishna2323 (High confidence)

Note on melvin-bot attribution: The auto-assigned PR #84657 was included in the regression test field of the issue body as the feature being tested, not the causing PR. The actual bug was discovered while testing that duplicate-expense feature.

Recommendation: REVERT

PR #85796 directly introduced the selection-mode Pay button with payment sub-menu (via the new useSelectionModeReportActions hook), and is already flagged as unchecked in the StagingDeployCash. The selection-mode "More > Pay" submenu is showing "Pay with personal account" instead of "Pay with wallet" for IOU reports with an activated wallet. Reverting this PR would remove the selection-mode Submit/Approve/Pay actions and restore the previous behavior.

Assigned: @Krishna2323 (PR author), @situchan (approving reviewer), @puneetlath (approving reviewer)
Labels: No label changes needed. DeployBlockerCash should remain as this is a Frontend bug in Expensify/App.

Detailed Analysis:

Evidence:

• The bug affects the "More > Pay" dropdown in bulk selection mode on an IOU report with USD expenses.
• Step 3 of the reproduction confirms "Pay with wallet" shows correctly for the single (non-bulk) Pay button, meaning the user has an activated wallet and the base payment logic is correct.
• Step 5 shows "Pay with personal account" in the bulk selection "More > Pay" submenu, which is a different code path.
• PR Add selection mode Submit/Approve/Pay actions for mobile layout. #85796 is the only staging PR that directly introduced the selection-mode payment sub-menu logic (via useSelectionModeReportActions) used by MoneyRequestReportActionsList.
• PR Add selection mode Submit/Approve/Pay actions for mobile layout. #85796 is unchecked (flagged) in the StagingDeployCash, consistent with it being a blocker.

Verification:

• Affected files: src/hooks/useSelectionModeReportActions.ts, src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx, src/components/MoneyReportHeader.tsx
• PR Add selection mode Submit/Approve/Pay actions for mobile layout. #85796 modifies all three files and introduces useSelectionModeReportActions.ts from scratch.
• The paymentSubMenuItems built inside useSelectionModeReportActions uses usePaymentOptions to determine payment option text.

Root Cause:
PR #85796 introduced useSelectionModeReportActions, which constructs the payment sub-menu for the selection-mode Pay action. The paymentSubMenuItems are built from paymentButtonOptions returned by usePaymentOptions. The personal payment option text is determined by: hasActivatedWallet ? translate("iou.settleWallet") : translate("iou.settlePersonal"). There is likely a subtle difference in how the hook resolves parameters in the new context versus the original MoneyReportHeader context, causing it to render "Pay with personal account" even when the wallet is activated.