[Due for payment 2026-04-14] [Due for payment 2026-04-14] Reports - Dropdown button shows Submit when one of the reports can only be marked as done

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.52-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #86460
Email or phone of affected tester (no customers): jsdjosidjiojisojio3@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Search

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with new Gmail account.
3. Skip work email step.
4. Select Track and budget expenses.
5. Complete the onboarding.
6. Create another workspace.
7. Create an expense in both workspace chats.
8. Go to Reports > Reports.
9. Bulk select both reports.
10. Click dropdown button.

Expected Result:

Dropdown button will not show Submit since one of the reports can only be marked as done instead of submitting.

Actual Result:

Dropdown button shows Submit when one of the reports can only be marked as done instead of submitting.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #86460

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

What is the root cause of that problem?

The bulk "Submit" button label in search is determined at src/hooks/useSearchBulkActions.ts:999 using selectedReports.every((report) => isSubmitAndClose(...)). This requires all selected reports to belong to a submit-and-close policy before showing "Mark as done". When the selection is mixed (one submit-and-close workspace + one normal workspace), .every() returns false and the label defaults to "Submit" — even though one of the reports should only be "marked as done".

The issue was introduced by #86460 which added the track-intent "Mark as done" label but only for the case where every selected report is submit-and-close.

What changes do you think we should make in order to solve the problem?

The expected behavior (per the issue) is that the dropdown should not show "Submit" when one of the selected reports can only be marked as done. The simplest fix is to prevent bulk submission when the selection contains a mix of submit-and-close and normal-submit reports — i.e., disable the submit bulk action for mixed selections, similar to how other incompatible bulk actions are handled.

Alternatively, if the product intent is to still allow the action, the label at line 999 could use .some() instead of .every() to show "Mark as done" whenever any selected report is submit-and-close (since those reports will be marked as done regardless of the label). However, this may be confusing if some reports are actually being submitted. The product team should clarify the desired UX for mixed selections.

Supporting evidence

• shouldShowSubmitOption (line 988-993) treats both submit-and-close and normal-submit reports identically since both have SUBMIT in allActions
• The actual submission handler (lines 1018-1023) processes each report individually with its respective policy, so the underlying action already works correctly per-report — only the displayed label is wrong
• isSubmitAndClose (src/libs/PolicyUtils.ts:894) checks policy?.approvalMode === CONST.POLICY.APPROVAL_MODE.OPTIONAL
• isTrackIntentUserSelector (src/selectors/Onboarding.ts:85) is a global user-level flag, not per-workspace

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

[jayeshmangwani]

@Valforte @dylanexpensify

For this issue, we need to confirm the expected behavior:

This user has one workspace without Workflows → Approvals enabled and one workspace with enabled. They’ve created one expense from a workspace with approvals enabled and another from a workspace without approvals.

When they select both reports from Reports tab → Reports, they can see the Submit button since both expenses are technically submittable.

In this scenario, what should be the expected behavior?

1. Should we hide the Submit button?
   (I don’t think we should, since both are submittable.)
2. Or should we keep the current behavior and continue showing the Submit button?

Please let me know what the expected behavior should be here.