[$250] Current User Not Displayed at Top of “From” Filter in Reports

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs Reproduction (Unable to reproduce)
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation (hyperlinked to channel name): #Product

Action Performed:

1. Navigate to Reports
2. Open the “From” filter
3. Review the list/order of users

Expected Result:

The current user (“You” / logged-in user) should:
Be clearly visible
Appear at the top of the list for quick access

Actual Result:

The current user is:
Not prioritized at the top

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @QichenZhu

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022038980512386436243
• Upwork Job ID: 2038980512386436243
• Last Price Increase: 2026-03-31

[shawnborton]

We think this is a regression from #75026 cc @mkzie2 @ZhenjaHorbach @NikkiWines @Beamanator

[MelvinBot]

Proposal

What is the root cause of that problem?

After thorough investigation, the codebase already has explicit logic to prioritize the current user at the top of the "From" filter list — in both the dropdown popup (UserSelectPopup) and the full-page selector (SearchFiltersParticipantsSelector).

Dropdown path (UserSelectPopup.tsx:94-111): Sorts the combined options list with selected items first, then the current user (matched by accountID === currentUserAccountID), then everyone else.

Full-page path (SearchFiltersParticipantsSelector.tsx:128-142): Extracts currentUserOption from getValidOptions() (which is populated when includeCurrentUser: true is passed) and places it as its own section at sectionIndex: 0 (top of list) with a "(You)" postfix.

Both paths pass includeCurrentUser: true through useSearchSelector → getValidOptions(), which correctly: (1) does NOT exclude the current user's email from personal details (OptionsListUtils/index.ts:2643), and (2) identifies and stores the current user as currentUserOption by matching personalDetail.login === currentUserEmail (OptionsListUtils/index.ts:2676-2678).

However, there are edge cases where currentUserOption could be null/undefined, causing the current-user-at-top logic to silently fail:

1. Race condition with Onyx data loading: If currentUserPersonalDetails.email hasn't loaded yet when getValidOptions runs, currentUserEmail would be '', and the if (currentUserEmail) guard at line 2640 would skip the current user identification entirely.

2. Missing login field: If the current user's entry in personalDetails lacks a login field, the email match at line 2676 would fail, leaving currentUserOption as undefined.

3. UserSelectPopup doesn't use currentUserOption at all: Unlike the full-page selector, the dropdown relies solely on accountID comparison in its sort. If the current user appears in recentReports as a chat report (where accountID might represent the other participant rather than the current user), the sort comparison would fail silently.

What changes do you think we should make in order to solve the problem?

1. Make UserSelectPopup use currentUserOption explicitly (like SearchFiltersParticipantsSelector does), rather than relying solely on accountID matching in a sort. This would add a dedicated current-user section at the top and add the "(You)" postfix for visual clarity.

2. Add a "(You)" postfix in UserSelectPopup for the current user option, matching the behavior of SearchFiltersParticipantsSelector which calls getDisplayNameForParticipant({shouldAddCurrentUserPostfix: true}).

3. Guard against currentUserOption being null: In SearchFiltersParticipantsSelector, add a fallback that checks currentUserAccountID in the personal details/recent reports lists if currentUserOption is null, similar to how UserSelectPopup does its accountID comparison.

What alternative solutions did you explore? (Optional)

• We considered whether the issue was about a completely different UI path, but confirmed that the "From" filter in Reports uses either UserSelectPopup (dropdown on wide screens) or SearchFiltersParticipantsSelector (full page via advanced filters) — both of which have current-user prioritization logic.
• We checked if CONST.EXPENSIFY_EMAILS_OBJECT could exclude the current user, but confirmed that includeCurrentUser: true overrides this exclusion at OptionsListUtils/index.ts:2643.

Note: The existing logic appears correct for the common case. This issue may be intermittent (data loading timing) or specific to certain account configurations. Reproducing reliably would help confirm the exact failure scenario.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @QichenZhu (External)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022038980512386436243

[shawnborton]

This is a regression so let's make sure the original PR author fixes and we don't pay out for a new bug bounty. Thanks team!

[trasnake87]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When opening the "From" filter in Reports search, the current logged-in user is not displayed at the top of the list for quick access. They should appear prominently at the top.

What is the root cause of that problem?

The root cause is in getValidOptions at https://github.com/Expensify/App/blob/main/src/libs/OptionsListUtils/index.ts#L2667-L2678. The currentUserOption is extracted by scanning personalDetailsOptions after it has already been truncated by optionsOrderBy with a maxPersonalDetailsElements limit. This limit is calculated as maxElements - recentReportOptions.length - workspaceChats.length, so when there are many recent reports, the personal details budget shrinks significantly (potentially to zero). Since optionsOrderBy keeps only the top N alphabetically-sorted names, the current user is silently dropped from personalDetailsOptions whenever their name falls outside the alphabetical cutoff. When this happens, currentUserRef.current remains undefined, and the SearchFiltersParticipantsSelector component (line 128) never creates the "current user at top" section because chatOptions.currentUserOption is falsy.

What changes do you think we should make in order to solve the problem?

We should ensure currentUserOption is resolved before the limiting sort, by scanning the full unfiltered personal details list. In src/libs/OptionsListUtils/index.ts, after line 2669 and before the loop at line 2671, we should find the current user from the original options if they weren't included in the truncated results:

personalDetailsOptions = optionsOrderBy(options.personalDetails, personalDetailsComparator, maxPersonalDetailsElements, filteringFunction, true);

// Ensure current user is always available as currentUserOption, even if truncated by the limit
if (config.includeCurrentUser && currentUserEmail) {
    const currentUserInResults = personalDetailsOptions.find((detail) => detail?.login === currentUserEmail);
    if (currentUserInResults) {
        currentUserRef.current = currentUserInResults;
    } else {
        const currentUserFromAll = options.personalDetails.find(
            (detail) => detail?.login === currentUserEmail && filteringFunction(detail),
        );
        if (currentUserFromAll) {
            currentUserRef.current = currentUserFromAll;
        }
    }
}

for (let i = 0; i < personalDetailsOptions.length; i++) {

This approach finds the current user from the complete options.personalDetails array when they were excluded by the page-size limit, guaranteeing currentUserOption is always populated regardless of list length or alphabetical position. The existing loop at line 2671 can then be simplified to only handle isBold and brickRoadIndicator formatting.

[trasnake87]

Contributor details
Your Expensify account email: trasnake87@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~010f770315ab181656

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!