Update prohibited expenses description copy#86146
Conversation
Simplify the description from the verbose two-sentence version to a concise single sentence as requested. Co-authored-by: James Dean <jamesdeanexpensify@users.noreply.github.com>
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 2dab5e5b..f8c26405 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -6522,8 +6522,7 @@ Fordern Sie Spesendetails wie Belege und Beschreibungen an, legen Sie Limits und
eReceiptsHint: `eBelege werden automatisch erstellt [für die meisten Kreditkartentransaktionen in USD](${CONST.DEEP_DIVE_ERECEIPTS}).`,
attendeeTracking: 'Teilnehmernachverfolgung',
attendeeTrackingHint: 'Verfolge die Pro-Kopf-Kosten für jede Ausgabe.',
- prohibitedDefaultDescription:
- 'Markiere alle Belege, auf denen Alkohol, Glücksspiel oder andere eingeschränkte Artikel erscheinen. Ausgaben mit Belegen, auf denen solche Positionen vorkommen, müssen manuell geprüft werden.',
+ prohibitedDefaultDescription: 'Markieren Sie Belege mit diesen Positionen zur manuellen Überprüfung.',
prohibitedExpenses: 'Verbotene Ausgaben',
alcohol: 'Alkohol',
hotelIncidentals: 'Nebenkosten im Hotel',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index f1200a74..0f0866e1 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -6545,8 +6545,7 @@ Rendez obligatoires des informations de dépense comme les reçus et les descrip
eReceiptsHint: `Les e-reçus sont créés automatiquement [pour la plupart des transactions par carte en USD](${CONST.DEEP_DIVE_ERECEIPTS}).`,
attendeeTracking: 'Suivi des participants',
attendeeTrackingHint: 'Suivez le coût par personne pour chaque dépense.',
- prohibitedDefaultDescription:
- 'Signalez tous les reçus où figurent de l’alcool, des jeux d’argent ou d’autres articles restreints. Les dépenses accompagnées de reçus contenant ces postes devront être examinées manuellement.',
+ prohibitedDefaultDescription: 'Signaler les reçus contenant ces postes pour examen manuel.',
prohibitedExpenses: 'Dépenses interdites',
alcohol: 'Alcool',
hotelIncidentals: 'Frais annexes d’hôtel',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 37cd7176..1e53fdd2 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -6508,8 +6508,7 @@ Richiedi dettagli sulle spese come ricevute e descrizioni, imposta limiti e valo
eReceiptsHint: `Le eReceipt vengono create automaticamente [per la maggior parte delle transazioni con carta in USD](${CONST.DEEP_DIVE_ERECEIPTS}).`,
attendeeTracking: 'Monitoraggio partecipanti',
attendeeTrackingHint: 'Tieni traccia del costo per persona per ogni spesa.',
- prohibitedDefaultDescription:
- 'Contrassegna tutte le ricevute in cui compaiono alcolici, gioco d’azzardo o altri articoli soggetti a restrizioni. Le spese con ricevute che includono queste voci richiederanno una revisione manuale.',
+ prohibitedDefaultDescription: 'Contrassegna le ricevute con queste voci di riga per una revisione manuale.',
prohibitedExpenses: 'Spese vietate',
alcohol: 'Alcol',
hotelIncidentals: 'Spese accessorie dell’hotel',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 8ea363a2..bf4e343c 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -6437,8 +6437,7 @@ ${reportName}
eReceiptsHint: `eReceiptsは[ほとんどの米ドル建てクレジット取引に対して自動作成されます](${CONST.DEEP_DIVE_ERECEIPTS})。`,
attendeeTracking: '出席者の追跡',
attendeeTrackingHint: '各経費について、1人あたりの費用を追跡します。',
- prohibitedDefaultDescription:
- 'アルコール、ギャンブル、その他の制限対象品目が含まれている領収書にフラグを付けてください。これらの品目が記載された領収書の経費は、手動での確認が必要になります。',
+ prohibitedDefaultDescription: 'これらの明細項目を含むレシートにフラグを付けて、手動で確認します。',
prohibitedExpenses: '禁止経費',
alcohol: 'アルコール',
hotelIncidentals: 'ホテル付帯費用',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 4978d187..42b6bd05 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -6488,8 +6488,7 @@ Vereis onkostendetails zoals bonnen en beschrijvingen, stel limieten en standaar
eReceiptsHint: `eReceipts worden automatisch aangemaakt [voor de meeste USD-credittransacties](${CONST.DEEP_DIVE_ERECEIPTS}).`,
attendeeTracking: 'Deelnemersregistratie',
attendeeTrackingHint: 'Houd de kosten per persoon bij voor elke uitgave.',
- prohibitedDefaultDescription:
- 'Markeer alle bonnen waarop alcohol, gokken of andere verboden artikelen voorkomen. Declaraties met bonnen waarop deze posten voorkomen, moeten handmatig worden gecontroleerd.',
+ prohibitedDefaultDescription: 'Markeer bonnen met deze regels voor handmatige controle.',
prohibitedExpenses: 'Verboden uitgaven',
alcohol: 'Alcohol',
hotelIncidentals: 'Hotelnevenkosten',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index a30d0aab..84d280b8 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -6483,8 +6483,7 @@ Wymagaj szczegółów wydatków, takich jak paragony i opisy, ustawiaj limity i
eReceiptsHint: `eParagony są automatycznie tworzone [dla większości transakcji kartą kredytową w USD](${CONST.DEEP_DIVE_ERECEIPTS}).`,
attendeeTracking: 'Śledzenie uczestników',
attendeeTrackingHint: 'Śledź koszt na osobę dla każdego wydatku.',
- prohibitedDefaultDescription:
- 'Oznacz paragony, na których występują alkohol, hazard lub inne zabronione pozycje. Wydatki z paragonami zawierającymi takie pozycje będą wymagały ręcznego sprawdzenia.',
+ prohibitedDefaultDescription: 'Oznacz paragony z tymi pozycjami do ręcznej weryfikacji.',
prohibitedExpenses: 'Wydatki niedozwolone',
alcohol: 'Alkohol',
hotelIncidentals: 'Dodatkowe opłaty hotelowe',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index b919fb7a..88cc2f48 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -6487,8 +6487,7 @@ Exija dados de despesas como recibos e descrições, defina limites e padrões e
eReceiptsHint: `eReceipts são criados automaticamente [para a maioria das transações em crédito em USD](${CONST.DEEP_DIVE_ERECEIPTS}).`,
attendeeTracking: 'Controle de participantes',
attendeeTrackingHint: 'Acompanhe o custo por pessoa de cada despesa.',
- prohibitedDefaultDescription:
- 'Marque todos os recibos em que apareçam bebidas alcoólicas, jogos de azar ou outros itens restritos. Despesas com recibos em que esses itens apareçam precisarão de revisão manual.',
+ prohibitedDefaultDescription: 'Marcar recibos com estes itens de linha para revisão manual.',
prohibitedExpenses: 'Despesas proibidas',
alcohol: 'Álcool',
hotelIncidentals: 'Despesas diversas de hotel',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 048c91e5..3db47c73 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -6326,7 +6326,7 @@ ${reportName}
eReceiptsHint: `电子收据会自动为[大多数美元信用卡交易](${CONST.DEEP_DIVE_ERECEIPTS})创建。`,
attendeeTracking: '参会者跟踪',
attendeeTrackingHint: '跟踪每笔报销的单人费用。',
- prohibitedDefaultDescription: '标记所有包含酒精、赌博或其他受限项目的收据。含有这些项目的收据报销将需要人工审核。',
+ prohibitedDefaultDescription: '将包含这些明细项目的收据标记为人工审核。',
prohibitedExpenses: '禁止报销的费用',
alcohol: '酒精',
hotelIncidentals: '酒店杂费',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
|
@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
luacmartins
left a comment
There was a problem hiding this comment.
It seems like we're missing spanish
|
The only failing check on this PR is PR Author Checklist, which is unrelated to code changes and doesn't require a code fix. All other checks are either passing or still running. Once the pending checks (tests, typecheck, ESLint, etc.) complete, the PR status should be clear. |
|
🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.50-0 🚀
Bundle Size Analysis (Sentry): |
|
I have failed to help you. I let you down and for that I am sorry. Please try again later. This may be due to a Claude outage (check here). Failure details: https://github.com/Expensify/Expensify/actions/runs/23647072047 |
|
Hi @MelvinBot. Any QA steps here? |
|
No QA @IuliiaHerets |
Summary
Simplifies the "Prohibited expenses" pane description in New Expensify from:
to:
The original text was repetitive ("receipts where ... appear" said twice). This is a copy-only change in
src/languages/en.ts.Note: Only the English (
en.ts) copy was updated. Translations in other language files may need corresponding updates.Test plan
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari