Revamp search page actions bar by bernhardoj · Pull Request #85508 · Expensify/App

bernhardoj · 2026-03-17T06:36:32Z

Explanation of Change

Revamp the search page actions bar. (This PR only adds the necessary component without being shown yet)

Add a header that shows the currently selected search type
Moves and resizes the input
Shows the applied filters next to the input, wrapped to the bottom
Add Display dropdown button (which includes Sort by, Group by, View, Limit results, and Edit columns menu)
Add a Save button that opens the save search page and shows all the applied filters
Moves the filter button to the right side

Fixed Issues

$ #84876
PROPOSAL:

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open Reports > Expenses
Press Display
Verify there is Sort by, Group by, Limit results, and Edit columns
Apply the option one by one and verify that it works fine
Switch to Reports tab > Display
Verify there is only the Sort by and Edit columns option
Switch to the Chats tab
Verify there is no Display dropdown button
Apply any filters from the Filters button
Verify that each filter is added as a chip next to the search input
Press the search input
Verify the search works fine
Press the Save button
Verify it opens the Save search page, showing all the applied filters
Press Save search
Verify the search query is saved successfully

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mp4

web.search.mp4

melvin-bot · 2026-03-17T07:40:01Z

@dubielzyk-expensify @aimane-chnaif One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2026-03-17T07:40:05Z

Many of the changes are renaming.

src/components/Search/FilterDropdowns/TextInputPopup.tsx

src/components/Search/hooks/useFilterFeedValue.tsx

src/components/Search/SearchPageHeader/SearchPageInputNarrow.tsx

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 65d7690e5f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/components/Search/hooks/useFilterFeedValue.tsx

src/components/Search/SearchPageHeader/SearchTypeMenuNarrow.tsx

src/pages/Search/SearchSavePage.tsx

bernhardoj · 2026-03-17T07:58:59Z

Lint is unrelated

codecov · 2026-03-17T11:05:06Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`93.60% <ø> (ø)`
src/ONYXKEYS.ts	`100.00% <ø> (ø)`
src/ROUTES.ts	`16.06% <100.00%> (+0.04%)`	⬆️
src/SCREENS.ts	`100.00% <ø> (ø)`
...stReportView/MoneyRequestReportTransactionList.tsx	`1.14% <ø> (ø)`
...mponents/Search/FilterDropdowns/DropdownButton.tsx	`92.30% <ø> (-0.29%)`	⬇️
.../SearchPageHeader/SearchActionsBarCreateButton.tsx	`93.87% <100.00%> (ø)`
...ts/Search/SearchPageHeader/useSearchFiltersBar.tsx	`71.87% <ø> (-3.13%)`	⬇️
src/components/Search/selectors/Search.ts	`100.00% <100.00%> (ø)`
src/hooks/useSearchBulkActions.ts	`0.00% <ø> (ø)`
... and 38 more
... and 218 files with indirect coverage changes

trjExpensify · 2026-03-19T13:13:07Z

Yeah, I think that derisks this PR from getting even bigger and considering shipping release 1 when it's production ready after a second PR to cover:

Remove the duplication of items appearing in both Filters and Display (i.e Group by, view etc are in both)
Make all selected filters appear in the Filters bar (only the current ones we expose do)
Remove “Save search” from the Filters RHP in lieu of the “Save” button we’ve now exposed
Sort order in Sort by

bernhardoj · 2026-03-19T15:25:25Z

could we put these changes behind a staging lock, so that QA can test this but we won't have to revert?

Done, made it so the revamp is applied for both dev and staging.

luacmartins · 2026-03-19T17:06:22Z

@bernhardoj we discussed this internally and we want to take a different approach with this PR to minimize the chances for regressions and problems replicating changes from old to new components down the line.

Can you please update this PR to:

Remove all UI changes to the Search page
Just create the necessary components that we'll display in the UI
In a follow up PR, we'll introduce only the UI changes that should reuse the components setup in this PR>

This way, this because a setup PR for the later PR. We reduce both the scope and the amount of changes here and the follow up PR will be responsible for bringing the UI changes to Search, without the need for a beta or the old/new component split.

It's ok for these new components to be unused in the code. Just add a comment to them saying something like

// NOTE: This is intentionally unused for now. It will be wired up in https://github.com/Expensify/App/issues/84876

dubielzyk-expensify · 2026-03-19T23:02:47Z

Commented in Slack, but I'm totally with you Tom. I think we should also

Remove the dupe of group by
Show all filters in filter RHP
Remove save button from filter RHP

bernhardoj · 2026-03-20T02:38:14Z

Done. I still keep the renaming and other minor things in this PR.

MelvinBot · 2026-03-20T08:46:30Z

🤖 Code Review

Overall this is a well-structured setup PR that scaffolds the new search actions bar components without wiring them to the UI yet. The renames, translations, and new type definitions are clean. A few items to address:

Issues

1. TextInputPopup.tsx — Misnamed type
The props type is called SingleSelectPopupProps but the component is TextInputPopup. Should be TextInputPopupProps for clarity.

2. DisplayPopup.tsx — Inconsistent state/setter naming
State is selectedDisplayFilter but the setter is setSelectedDisplayModifier. The setter should be setSelectedDisplayFilter (or vice-versa) to follow the conventional [foo, setFoo] pattern.

3. SearchAdvanceFiltersButton — Typo in name
Should be SearchAdvancedFiltersButton (with a "d") to be consistent with the existing SearchAdvancedFilters, SEARCH_ADVANCED_FILTERS, AdvancedSearchFilters, etc.

4. File/function name mismatch in hooks

useFilterFromValue.tsx exports useFilterFromValues (plural)
useFilterWorkspaceValue.tsx exports useFilterWorkspaceValues (plural)
useFilterFeedValue.tsx exports useFilterFeedValues (plural)

The file names should match the exported function names (either all singular or all plural).

5. SearchPageInputWide.tsx — Commented-out code
Lines with // inputContainerStyle=... and // touchableInputWrapperStyle=... should be removed before merge.

6. Missing sentryLabel on SearchSaveButton
Other new buttons in this PR (SearchAdvanceFiltersButton, SearchDisplayDropdownButton) have sentryLabel props, but SearchSaveButton's Button does not. Add one for consistency and observability.

Minor / Non-blocking

The perf-tests check is failing — appears to be a pre-existing/flaky issue unrelated to this PR.
typeOptionsPoliciesSelector is now exported from both useSearchFiltersBar.tsx and useSearchActionsBar.tsx. The test was updated to import from the new location, but it would be good to confirm the old export can be removed to avoid duplication.

Otherwise the component architecture, the mapFiltersFormToLabelValueList utility, the new SearchSavePage, and all the translation additions look solid. Nice work keeping the new components isolated with the // NOTE: This is intentionally unused for now comments.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5700da2207

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-20T09:03:24Z

src/pages/Search/SearchSavePage.tsx

+    const queryString = (() => {
+        const {view, groupBy, sortBy, sortOrder, limit} = getCurrentSearchQueryJSON() ?? {};
+        return buildFilterQueryWithSortDefaults(searchAdvancedFiltersForm, {view, groupBy}, {sortBy, sortOrder, limit}) ?? '';
+    })();
+    const queryJSON = buildSearchQueryJSON(queryString || buildCannedSearchQuery());


Derive the save query from the live search state

If SearchSavePage is opened after a refresh/deep link, or any time SEARCH_ADVANCED_FILTERS_FORM is stale, this code rebuilds queryJSON from the cached form instead of the active search route. Unlike useSearchFiltersBar() (src/components/Search/SearchPageHeader/useSearchFiltersBar.tsx:123-124), this page never calls useFilterFormValues()/useSearchFilterSync(), so saveSearch() and applyFiltersAndNavigate() can silently save or reopen the wrong query (often an older search or the canned default).

Useful? React with 👍 / 👎.

aimane-chnaif · 2026-03-20T10:56:47Z

src/components/Search/FilterDropdowns/DropdownButton.tsx

    const calculatePopoverPositionAndToggleOverlay = useCallback(() => {
        calculatePopoverPosition(anchorRef, ANCHOR_ORIGIN).then((pos) => {
-            setPopoverTriggerPosition({...pos, vertical: pos.vertical + PADDING_MODAL});
+            setPopoverTriggerPosition({...pos, vertical: pos.vertical});


before:

after:

cc: @Expensify/design for confirmation

Let's not change it in this PR. Please revert these changes.

src/ROUTES.ts

src/components/Search/FilterDropdowns/DisplayPopup.tsx

aimane-chnaif · 2026-03-20T12:11:29Z

src/components/Search/hooks/useFilterFeedValue.tsx

+        return '';
+    }
+
+    const feedsForDisplay = getCardFeedsForDisplay(allFeeds, personalAndWorkspaceCards, translate, feedKeysWithCards);


App/src/hooks/useAutocompleteSuggestions.ts

Lines 362 to 365 in d05d2a0

case CONST.SEARCH.SYNTAX_FILTER_KEYS.FEED: {

// We don't want to show the "Expensify Card" feeds in the autocomplete suggestion list as they don't have real "Statements"

// Thus passing an empty object to the `allCards` parameter.

const feedAutoCompleteList = Object.values(getCardFeedsForDisplay(allFeeds, {}, translate, feedKeysWithCards));

Should this comment apply here too?

Hmm, when showing the feed options for the filter, we pass all cards

App/src/libs/SearchUIUtils.ts

Lines 4051 to 4058 in 417c2b1

function getFeedOptions(

allCardFeeds: OnyxCollection<OnyxTypes.CardFeeds>,

allCards: OnyxTypes.CardList | undefined,

translate: LocalizedTranslate,

localeCompare: LocaleContextProps['localeCompare'],

feedKeysWithCards?: FeedKeysWithAssignedCards,

) {

return Object.values(getCardFeedsForDisplay(allCardFeeds, allCards, translate, feedKeysWithCards))

App/src/components/Search/SearchPageHeader/useSearchFiltersBar.tsx

Line 180 in 417c2b1

const feedOptions = getFeedOptions(allFeeds, personalAndWorkspaceCards, translate, localeCompare, feedKeysWithCards);

aimane-chnaif · 2026-03-20T12:16:01Z

src/components/Search/SearchPageHeader/SearchPageInputNarrow.tsx

+    handleSearch: (value: string) => void;
+};
+// NOTE: This is intentionally unused for now. It will be wired up in https://github.com/Expensify/App/issues/84876
+function SearchPageInputNarrow({queryJSON, searchRouterListVisible, hideSearchRouterList, onSearchRouterFocus, handleSearch}: SearchPageInputNarrowProps) {


Pretty much overlap with SearchPageInputWide. Can we extract same logic to avoid code duplication?

Hmm, you're right, but the component return is quite different. I think we can extract this into a hook.

Yea, let's extract this into a hook

aimane-chnaif · 2026-03-20T12:21:01Z

Should this PR be [No QA] as new pages are not visible yet?

aimane-chnaif · 2026-03-20T12:37:33Z

Processing measurement 1: useAdvancedSearchFilters hook initial render with policies
Error: Render count difference exceeded the allowed deviation of 0. Current difference: 0.8

@MelvinBot perf tests failing very often. Can you investigate this and implement fix in separate PR?

MelvinBot · 2026-03-20T12:54:19Z

🔍 Perf Test Flakiness Investigation

Summary: The useAdvancedSearchFilters hook initial render with policies perf test failure is a pre-existing flaky test, not caused by this PR. It was introduced today via #85449 and is immediately flaky.

Root Cause: The useAdvancedSearchFilters hook has 7+ useOnyx subscriptions. The reassure CI runs the test suite twice in the same job (once for baseline on main, once for the PR branch). The second run consistently produces an extra render ~80% of the time due to Onyx subscription batching timing differences, giving a mean render count of 1.80 vs the baseline's 1.0 — a difference of 0.8 which exceeds the strict COUNT_DEVIATION: 0 threshold.

Evidence: The exact same failure (1 -> 1.80, +0.80) appears across dozens of completely unrelated PRs (accessibility, travel cards, onboarding, etc.) — none of which modify the hook or the test.

Recommended Fix: Change COUNT_DEVIATION from 0 to 1 in .github/workflows/reassurePerformanceTests.yml:72. This tolerates the environmental noise (0.8 diff) while still catching real regressions (2+ extra renders).

- COUNT_DEVIATION: 0
+ COUNT_DEVIATION: 1

Blocker: I was unable to push this fix as a separate PR because the GitHub PAT lacks the workflow scope required to modify .github/workflows/ files. A team member with appropriate permissions will need to push this one-line change.

JS00001 · 2026-03-20T13:12:02Z

This should prob be no QA yes

aimane-chnaif · 2026-03-20T14:06:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

aimane-chnaif · 2026-03-20T14:07:17Z

There's typescript error. And please merge main.

luacmartins · 2026-03-20T17:34:52Z

src/components/Search/FilterDropdowns/DropdownButton.tsx

    const calculatePopoverPositionAndToggleOverlay = useCallback(() => {
        calculatePopoverPosition(anchorRef, ANCHOR_ORIGIN).then((pos) => {
-            setPopoverTriggerPosition({...pos, vertical: pos.vertical + PADDING_MODAL});
+            setPopoverTriggerPosition({...pos, vertical: pos.vertical});


Let's not change it in this PR. Please revert these changes.

luacmartins · 2026-03-20T17:40:53Z

src/components/Search/SearchPageHeader/SearchPageInputNarrow.tsx

+    handleSearch: (value: string) => void;
+};
+// NOTE: This is intentionally unused for now. It will be wired up in https://github.com/Expensify/App/issues/84876
+function SearchPageInputNarrow({queryJSON, searchRouterListVisible, hideSearchRouterList, onSearchRouterFocus, handleSearch}: SearchPageInputNarrowProps) {


Yea, let's extract this into a hook

luacmartins · 2026-03-20T17:43:38Z

src/components/Search/SearchPageHeader/SearchSaveButton.tsx

+import CONST from '@src/CONST';
+import ROUTES from '@src/ROUTES';
+
+function SearchSaveButton() {


This component seems unnecessary. It's just a wrapper around Button and called in two places. We could just pass the props from the parent components.

luacmartins · 2026-03-20T17:45:04Z

src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.tsx

+                            <Stack.Screen
+                                name={SCREENS.RIGHT_MODAL.SEARCH_SAVE}
+                                component={SearchSavePage}
+                            />


Why are we still adding this screen in this PR? We shouldn't be changing the UI in this PR.

luacmartins · 2026-03-20T17:45:15Z

src/libs/Navigation/linkingConfig/RELATIONS/SEARCH_TO_RHP.ts

        SCREENS.MONEY_REQUEST.SPLIT_EXPENSE_SEARCH,
        SCREENS.RIGHT_MODAL.SEARCH_MONEY_REQUEST_REPORT,
        SCREENS.RIGHT_MODAL.SEARCH_REPORT,
+        SCREENS.RIGHT_MODAL.SEARCH_SAVE,


Same here and for other navigation related changes

revamp search page actions bar

55b608d

melvin-bot bot assigned bernhardoj Mar 17, 2026

bernhardoj added 4 commits March 17, 2026 15:01

add other translations

8ffd9da

lint

58e2fed

lint

1154d89

fix wrong hooks being used

65d7690

bernhardoj marked this pull request as ready for review March 17, 2026 07:39

bernhardoj requested review from a team as code owners March 17, 2026 07:39

melvin-bot bot requested review from aimane-chnaif, dubielzyk-expensify and trjExpensify and removed request for a team March 17, 2026 07:39

melvin-bot bot removed the request for review from a team March 17, 2026 07:40

github-actions bot reviewed Mar 17, 2026

View reviewed changes

src/components/Search/FilterDropdowns/TextInputPopup.tsx Show resolved Hide resolved

github-actions bot reviewed Mar 17, 2026

View reviewed changes

src/components/Search/hooks/useFilterFeedValue.tsx Outdated Show resolved Hide resolved

github-actions bot reviewed Mar 17, 2026

View reviewed changes

src/components/Search/SearchPageHeader/SearchPageInputNarrow.tsx Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 17, 2026

View reviewed changes

src/components/Search/hooks/useFilterFeedValue.tsx Outdated Show resolved Hide resolved

src/components/Search/SearchPageHeader/SearchTypeMenuNarrow.tsx Outdated Show resolved Hide resolved

src/pages/Search/SearchSavePage.tsx Outdated Show resolved Hide resolved

fix extra spaces and label

3e2eefd

bernhardoj added 5 commits March 17, 2026 16:02

fix search name is saved as empty string

3f42ae1

don't include unfound card

83f189d

make it optional

a7aa479

fix test

afca3f7

remove IIFE pattern

3b92af9

create a map lookup to optimize

ef3265d

bernhardoj added 2 commits March 19, 2026 21:40

remove unused var

89125e0

only render the revamped search actions bar if it's on staging/dev

359db31

bernhardoj added 5 commits March 20, 2026 10:30

don't show the new component yet

f332aa3

remove unused import

d55abd9

fix test

0d3b6ae

fix missing style

0e07500

update test

a3dc7db

bernhardoj added 2 commits March 20, 2026 10:41

remove unused prop

7aaf5eb

remove unused prop

5700da2

chatgpt-codex-connector bot reviewed Mar 20, 2026

View reviewed changes

bernhardoj added 3 commits March 20, 2026 19:38

fix wrong name

060b191

make the name consistent

abaec93

add sentry label

754b10b

aimane-chnaif reviewed Mar 20, 2026

View reviewed changes

bernhardoj added 2 commits March 20, 2026 21:03

refactor to use formprovider and make it autofocus

a91a01a

show groupby for trip too

bedfb8a

luacmartins reviewed Mar 20, 2026

View reviewed changes

	case CONST.SEARCH.SYNTAX_FILTER_KEYS.FEED: {
	// We don't want to show the "Expensify Card" feeds in the autocomplete suggestion list as they don't have real "Statements"
	// Thus passing an empty object to the `allCards` parameter.
	const feedAutoCompleteList = Object.values(getCardFeedsForDisplay(allFeeds, {}, translate, feedKeysWithCards));

	function getFeedOptions(
	allCardFeeds: OnyxCollection<OnyxTypes.CardFeeds>,
	allCards: OnyxTypes.CardList \| undefined,
	translate: LocalizedTranslate,
	localeCompare: LocaleContextProps['localeCompare'],
	feedKeysWithCards?: FeedKeysWithAssignedCards,
	) {
	return Object.values(getCardFeedsForDisplay(allCardFeeds, allCards, translate, feedKeysWithCards))

Conversation

bernhardoj commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 17, 2026

Uh oh!

bernhardoj commented Mar 17, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bernhardoj commented Mar 17, 2026

Uh oh!

codecov bot commented Mar 17, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

trjExpensify commented Mar 19, 2026

Uh oh!

bernhardoj commented Mar 19, 2026

Uh oh!

luacmartins commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dubielzyk-expensify commented Mar 19, 2026

Uh oh!

bernhardoj commented Mar 20, 2026

Uh oh!

MelvinBot commented Mar 20, 2026

🤖 Code Review

Issues

Minor / Non-blocking

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented Mar 20, 2026

Uh oh!

aimane-chnaif commented Mar 20, 2026

Uh oh!

MelvinBot commented Mar 20, 2026

🔍 Perf Test Flakiness Investigation

Uh oh!

JS00001 commented Mar 20, 2026

Uh oh!

aimane-chnaif commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

bernhardoj commented Mar 17, 2026 •

edited

Loading

codecov bot commented Mar 17, 2026 •

edited by github-actions bot

Loading

luacmartins commented Mar 19, 2026 •

edited

Loading

aimane-chnaif commented Mar 20, 2026 •

edited

Loading