[Due for payment 2026-01-13] [Due for payment 2025-12-17] [$250] Confirm page loads infinitely after opening scan shortcut and opening create manual from QAB

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.57-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #72714
Email or phone of affected tester (no customers): sjidonjdsoisdjsod2@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create an expense.
4. Open primary receipt scan button.
5. Close the RHP.
6. Open FAB.
7. Click Create expense under Quick action.
8. Enter amount > Next.

Expected Result:

Confirm page will not load infinitely.

Actual Result:

Confirm page shows Scan confirm page when it is a manual expense and it loads infinitely.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug7002428_1763011482052.10.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021993335218775137514
• Upwork Job ID: 1993335218775137514
• Last Price Increase: 2025-12-02
• Automatic offers:
• FitseTLT | Contributor | 109685468

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Confirm page loads infinitely after opening scan shortcut and opening create manual from QAB

What is the root cause of that problem?

We show FullScreenLoadingIndicator when the draft transaction type is scan and when there is no receipt file

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 1244 in 7a03967

{(isLoading || (isScanRequest(transaction) && !Object.values(receiptFiles).length)) && <FullScreenLoadingIndicator />}

We initialize draft transaction with the new newIOUType

App/src/pages/iou/request/IOURequestStartPage.tsx

Lines 161 to 171 in 7a03967

	initMoneyRequest({
	reportID,
	policy,
	isFromGlobalCreate: transaction?.isFromGlobalCreate ?? isFromGlobalCreate,
	currentIouRequestType: transaction?.iouRequestType,
	newIouRequestType: newIOUType,
	report,
	parentReport,
	currentDate,
	lastSelectedDistanceRates,
	currentUserPersonalDetails,

we calculate newIOUType here. When shouldUseTab is true and when the previously selected tab is not perdiem we assign selectedTab (previously visited tab) to newIOUType which is scan

App/src/pages/iou/request/IOURequestStartPage.tsx

Lines 109 to 121 in 7a03967

	const transactionRequestType = useMemo(() => {
	if (!transaction?.iouRequestType) {
	if (shouldUseTab) {
	if (selectedTab === CONST.TAB_REQUEST.PER_DIEM && !shouldShowPerDiemOption) {
	return undefined;
	}
	return selectedTab;
	}
	return CONST.IOU.REQUEST_TYPE.MANUAL;
	}
	return transaction.iouRequestType;

What changes do you think we should make in order to solve the problem?

We should make shouldUseTab false if the iouType type is sbumit

 const shouldUseTab = iouType !== CONST.IOU.TYPE.SEND && iouType !== CONST.IOU.TYPE.PAY && iouType !== CONST.IOU.TYPE.INVOICE && iouType !== CONST.IOU.TYPE.SUBMIT;

App/src/pages/iou/request/IOURequestStartPage.tsx

Line 66 in 7a03967

const shouldUseTab = iouType !== CONST.IOU.TYPE.SEND && iouType !== CONST.IOU.TYPE.PAY && iouType !== CONST.IOU.TYPE.INVOICE;

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Confirm page loads infinitely after opening scan shortcut and opening create manual from QAB

What is the root cause of that problem?

When selectedTab was scan and we use QAB with manual request type set the selectedTab is updated from the current route

App/src/libs/Navigation/OnyxTabNavigator.tsx

Line 197 in 7a03967

Tab.setSelectedTab(id, newSelectedTab as SelectedTabRequest);

but it happens too slow and this effect here is run with the transactionRequestType calculated from the old selectedTab which was scan

App/src/pages/iou/request/IOURequestStartPage.tsx

Lines 189 to 195 in 7a03967

	useFocusEffect(
	useCallback(() => {
	// The test transaction can change the reportID of the transaction on the flow so we should prevent the reportID from being reverted again.
	if (transaction?.reportID === reportID || isLoadingSelectedTab || !transactionRequestType || prevTransactionReportID !== transaction?.reportID) {
	return;
	}
	resetIOUTypeIfChanged(transactionRequestType);

so the transaction iouRequestType will be set to scan and when we reach the confirmation screen we will see loading because it is understood as scan request type transaction without receipt

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 1244 in 7a03967

{(isLoading || (isScanRequest(transaction) && !Object.values(receiptFiles).length)) && <FullScreenLoadingIndicator />}

What changes do you think we should make in order to solve the problem?

The effect is suppose to run when there is a change of reportID but in our case it runs because the transaction data is still loading from onxy so we can avoid the effect here when the transaction data is still loading from onyx

App/src/pages/iou/request/IOURequestStartPage.tsx

Lines 189 to 195 in 7a03967

	useFocusEffect(
	useCallback(() => {
	// The test transaction can change the reportID of the transaction on the flow so we should prevent the reportID from being reverted again.
	if (transaction?.reportID === reportID || isLoadingSelectedTab || !transactionRequestType || prevTransactionReportID !== transaction?.reportID) {
	return;
	}
	resetIOUTypeIfChanged(transactionRequestType);

    const isLoadingTransaction = isLoadingOnyxValue(transactionResult);

   // Clear out the temporary expense if the reportID in the URL has changed from the transaction's reportID.
    useFocusEffect(
        useCallback(() => {
            // The test transaction can change the reportID of the transaction on the flow so we should prevent the reportID from being reverted again.
            if (transaction?.reportID === reportID || isLoadingTransaction || isLoadingSelectedTab || !transactionRequestType || prevTransactionReportID !== transaction?.reportID) {
                return;
            }
            resetIOUTypeIfChanged(transactionRequestType);
        }, [transaction?.reportID, reportID, resetIOUTypeIfChanged, isLoadingTransaction, transactionRequestType, isLoadingSelectedTab, prevTransactionReportID]),
    );

Alternatively, just like we did here for the quick scan flow to solve a similar bug

App/src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx

Line 307 in 7a03967

Tab.setSelectedTab(CONST.TAB.IOU_REQUEST_TYPE, CONST.IOU.REQUEST_TYPE.SCAN);

we will need to set the tab here

App/src/libs/actions/QuickActionNavigation.ts

Line 42 in 7a03967

const requestType = getQuickActionRequestType(quickAction?.action, lastDistanceExpenseType);

 if (requestType) {
        Tab.setSelectedTab(CONST.TAB.IOU_REQUEST_TYPE, requestType);
    }

so that the selected tab data is ready when we reach start page

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021993335218775137514

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)