From f0c62d62f84909eda0d670c79b79006c62e21c84 Mon Sep 17 00:00:00 2001
From: Marc Henry de Frahan <marc.henrydefrahan@nrel.gov>
Date: Fri, 20 Sep 2024 14:56:50 -0600
Subject: [PATCH] fix warn

---
 amr-wind/utilities/sampling/DTUSpinnerSampler.H  | 3 ++-
 amr-wind/utilities/sampling/FreeSurfaceSampler.H | 3 ++-
 amr-wind/utilities/sampling/LineSampler.H        | 3 ++-
 amr-wind/utilities/sampling/PlaneSampler.H       | 3 ++-
 amr-wind/utilities/sampling/ProbeSampler.H       | 3 ++-
 amr-wind/utilities/sampling/RadarSampler.H       | 5 +++--
 amr-wind/utilities/sampling/VolumeSampler.H      | 3 ++-
 7 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/amr-wind/utilities/sampling/DTUSpinnerSampler.H b/amr-wind/utilities/sampling/DTUSpinnerSampler.H
index 53a21bc0bc..cbe2e60538 100644
--- a/amr-wind/utilities/sampling/DTUSpinnerSampler.H
+++ b/amr-wind/utilities/sampling/DTUSpinnerSampler.H
@@ -46,7 +46,8 @@ public:
     //! Populate the vector with coordinates of the sampling locations inside
     //! boxes
     void sampling_locations(
-        SampleLocType&, const amrex::Vector<amrex::Box>&) const override;
+        SampleLocType& /*sample_locs**/,
+        const amrex::Vector<amrex::Box>& /*boxes*/) const override;
 
     static vs::Vector generate_lidar_pattern(
         PrismParameters InnerPrism, PrismParameters OuterPrism, double time);
diff --git a/amr-wind/utilities/sampling/FreeSurfaceSampler.H b/amr-wind/utilities/sampling/FreeSurfaceSampler.H
index 003df63b03..6a0e72080f 100644
--- a/amr-wind/utilities/sampling/FreeSurfaceSampler.H
+++ b/amr-wind/utilities/sampling/FreeSurfaceSampler.H
@@ -28,7 +28,8 @@ public:
     //! Populate the vector with coordinates of the sampling locations inside
     //! boxes
     void sampling_locations(
-        SampleLocType&, const amrex::Vector<amrex::Box>&) const override;
+        SampleLocType& /*sample_locs**/,
+        const amrex::Vector<amrex::Box>& /*boxes*/) const override;
 
     void output_locations(SampleLocType& sample_locs) const override
     {
diff --git a/amr-wind/utilities/sampling/LineSampler.H b/amr-wind/utilities/sampling/LineSampler.H
index e0ad2c5cb2..eb651903c1 100644
--- a/amr-wind/utilities/sampling/LineSampler.H
+++ b/amr-wind/utilities/sampling/LineSampler.H
@@ -36,7 +36,8 @@ public:
     //! Populate the vector with coordinates of the sampling locations inside
     //! boxes
     void sampling_locations(
-        SampleLocType&, const amrex::Vector<amrex::Box>&) const override;
+        SampleLocType& /*sample_locs**/,
+        const amrex::Vector<amrex::Box>& /*boxes*/) const override;
 
     void output_locations(SampleLocType& sample_locs) const override
     {
diff --git a/amr-wind/utilities/sampling/PlaneSampler.H b/amr-wind/utilities/sampling/PlaneSampler.H
index 9d1b9aa63d..d61f5c1b53 100644
--- a/amr-wind/utilities/sampling/PlaneSampler.H
+++ b/amr-wind/utilities/sampling/PlaneSampler.H
@@ -47,7 +47,8 @@ public:
     //! Populate the vector with coordinates of the sampling locations inside
     //! boxes
     void sampling_locations(
-        SampleLocType&, const amrex::Vector<amrex::Box>&) const override;
+        SampleLocType& /*sample_locs**/,
+        const amrex::Vector<amrex::Box>& /*boxes*/) const override;
 
     void output_locations(SampleLocType& sample_locs) const override
     {
diff --git a/amr-wind/utilities/sampling/ProbeSampler.H b/amr-wind/utilities/sampling/ProbeSampler.H
index 5854c24ea3..eedd12a3fc 100644
--- a/amr-wind/utilities/sampling/ProbeSampler.H
+++ b/amr-wind/utilities/sampling/ProbeSampler.H
@@ -34,7 +34,8 @@ public:
     //! Populate the vector with coordinates of the sampling locations inside
     //! boxes
     void sampling_locations(
-        SampleLocType&, const amrex::Vector<amrex::Box>&) const override;
+        SampleLocType& /*sample_locs**/,
+        const amrex::Vector<amrex::Box>& /*boxes*/) const override;
 
     void output_locations(SampleLocType& sample_locs) const override
     {
diff --git a/amr-wind/utilities/sampling/RadarSampler.H b/amr-wind/utilities/sampling/RadarSampler.H
index bd9f5d418d..5383dc2217 100644
--- a/amr-wind/utilities/sampling/RadarSampler.H
+++ b/amr-wind/utilities/sampling/RadarSampler.H
@@ -52,7 +52,8 @@ public:
     //! Populate the vector with coordinates of the sampling locations inside
     //! boxes
     void sampling_locations(
-        SampleLocType&, const amrex::Vector<amrex::Box>&) const override;
+        SampleLocType& /*sample_locs**/,
+        const amrex::Vector<amrex::Box>& /*boxes*/) const override;
 
     bool update_sampling_locations() override;
     void cone_axis_locations(SampleLocType& /*sample_locs**/) const;
@@ -199,7 +200,7 @@ protected:
     long m_num_points_prior;
     long m_num_output_points_prior;
 
-    double m_fill_val{-99999.99};
+    amrex::Real m_fill_val{-99999.99};
 };
 
 } // namespace amr_wind::sampling
diff --git a/amr-wind/utilities/sampling/VolumeSampler.H b/amr-wind/utilities/sampling/VolumeSampler.H
index d1974dba75..4738c296ae 100644
--- a/amr-wind/utilities/sampling/VolumeSampler.H
+++ b/amr-wind/utilities/sampling/VolumeSampler.H
@@ -37,7 +37,8 @@ public:
     //! Populate the vector with coordinates of the sampling locations inside
     //! boxes
     void sampling_locations(
-        SampleLocType&, const amrex::Vector<amrex::Box>&) const override;
+        SampleLocType& /*sample_locs**/,
+        const amrex::Vector<amrex::Box>& /*boxes*/) const override;
 
     void output_locations(SampleLocType& sample_locs) const override
     {