add event for GameLoader.LoadThread
#985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddie480-bot
added
the
review needed
Kalobi
approved these changes
Sep 6, 2025
SnipUndercover
requested changes
Sep 6, 2025
Member
There was a problem hiding this comment.
LGTM, but I'd like some clarification that this event is invoked right before setting loaded = true;.
Also, this event should probably be invoked before the Console.WriteLine(...); and LoadTimer.Stop(); calls, so that mods' effect on the game load times can be measured.
maddie480-bot
added
changes requested
SnipUndercover
approved these changes
Sep 13, 2025
Member
|
The pull request was approved and entered the 3-day last-call window. |
maddie480-bot
added
last call window
Member
|
The last-call window for this pull request ended. It can now be merged if no blockers were brought up. |
maddie480-bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in analogy to the existing
LevelLoader.LoadingThreadevent