Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traincraft book in multiple languages? #240

Open
Kofola45cz opened this issue Feb 1, 2017 · 11 comments
Open

Traincraft book in multiple languages? #240

Kofola45cz opened this issue Feb 1, 2017 · 11 comments

Comments

@Kofola45cz
Copy link

Kofola45cz commented Feb 1, 2017

It would be possible dependence nastaveního language in Minecraft to automatically change the text in Traincraft book?
It would be done somewhere so players could send the translated text, what is the need to translate Traincraft was more language that is never a bad thing? For example, Czech,....
Translated into google, so sorry for the English

pages 2-18
postimage
postimage

@NitroxydeX
Copy link
Collaborator

atm the book can't be translated into other languages due to our own limitations

@Kofola45cz
Copy link
Author

Kofola45cz commented Feb 1, 2017

hmm,...
NitroxydeX, but it would need to make a recipe for crafting other books for language else? I'm just asking, if not understand ...

@EternalBlueFlame
Copy link
Owner

EternalBlueFlame commented Feb 1, 2017

I know this issue well from the rewrite, spent some time working with stuff like this.
It is actually possible to have it done in the port, but the issue is that it's a LOT of text to replace with language file calls, and most translations won't fit the book properly due to different word/sentence sizes.
Not to mention language files can't cover things like line breaks, so we'd have to rely on the word wrap.

Other books would be even more complex because of the save data and networking systems that try to save the last known page, and it would likely have to have new pages added or even pages removed.
Plus we would need programmers that speak other languages to write the books, its not just simple language file modification that the average person can so easily understand how to do.

@Kofola45cz
Copy link
Author

hmm...

@detjensrobert
Copy link

If it is possible to save the pages as an image file each, maybe depending on the selected language display a different image of the translated book? That way you could have people just edit the text in the images and translate it that way.

@EternalBlueFlame
Copy link
Owner

it would be possible but again, would require the entire book to be remade.

@EzerArch
Copy link

EzerArch commented Feb 4, 2017

If it is possible to save the pages as an image file each (...)

If it's going to load something, why not txt/json files? A player event (right-clicking the book) would check the current language and then load the relevant manual file from, say, assets\tc\texts\manual\en_US.txt into book UI. Much like, Minecraft loads txt files from assets\minecraft\texts\*.txt.

@EternalBlueFlame
Copy link
Owner

EternalBlueFlame commented Feb 4, 2017

It is actually possible to have it done in the port, but the issue is that it's a LOT of text to replace with language file calls, and most translations won't fit the book properly due to different word/sentence sizes.
Not to mention language files can't cover things like line breaks, so we'd have to rely on the word wrap.

We can do a custom format loader like for txt or JSON, but then the issue on top of the above is that we need something to parse it, and that kinda code can get rather messy, for example here was an XML parse I made https://github.com/EternalBlueFlame/EternalMediaBar/blob/master/app/src/main/java/com/ebf/eternalmediabar/SettingsClass.java .

I do have this stuff handled in the rewrite, but it is significantly more difficult in the port due to design.

@NitroxydeX
Copy link
Collaborator

And to mention this here: We talked about the book and are not really sure if we're going to provide it in the rewrite of 1.7.10 and 1.11. There are other ways to display recipes (NEI, JEI, Wiki). If we need to provide additional information we can easily do this by shift hover over the item.

@EternalBlueFlame
Copy link
Owner

eh, I'll probably put it in the 1.7 rewrite, its a nice reference to go alongside the crafting guide stuff (which not everyone uses by the way), and with the system for keys and stuff i found a nice way to save the last known page, even between sessions, without needing packets.
Besides that, no one can even seem to read a readme on github, let alone be bothered to look for a wiki link, or worse, use a search engine - dramatic music here-.

@SuperKingJulian2
Copy link

And to mention this here: We talked about the book and are not really sure if we're going to provide it in the rewrite of 1.7.10 and 1.11. There are other ways to display recipes (NEI, JEI, Wiki). If we need to provide additional information we can easily do this by shift hover over the item.

sadly some recipes doesnt show correctly in NeI so the guide is still a good thing to have :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants