chore: update tiktoken to 0.8 to support py3.13 build #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Chen <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to ed914c7 in 11 seconds
More details
- Looked at
13lines of code in1files - Skipped
1files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. pyproject.toml:26
- Draft comment:
Ensure compatibility with tiktoken 0.8.0 by reviewing its changelog for any breaking changes or necessary adjustments in the codebase. - Reason this comment was not posted:
Confidence changes required:33%
The PR updates the tiktoken dependency from version 0.7 to 0.8. This change is straightforward and aligns with the PR description, which mentions the need to support Python 3.13 builds. The changelog for tiktoken 0.8.0 should be reviewed to ensure compatibility and no breaking changes, but this is not part of the code review process. The rest of the pyproject.toml file remains unchanged, which is expected for this PR.
Workflow ID: wflow_cgK4lgsHfKzKEpWN
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
actually also need huggingface/tokenizers#1639 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update tiktoken to 0.8 to support py3.13 build
tiktoken 0.8.0 changelog notes, https://github.com/openai/tiktoken/blob/main/CHANGELOG.md#v080
relates to Homebrew/homebrew-core#194427