Skip to content

Commit b55afa0

Browse files
sjg20trini
authored andcommitted
disk: Rename block_dev to desc
The use of 'block_dev' in this context is confusing, since it is not a pointer to a device, just to some information about it. Rename this to 'desc', as is more commonly used, since it is a block descriptor. Signed-off-by: Simon Glass <[email protected]> Acked-by: Heinrich Schuchardt <[email protected]>
1 parent 76c839f commit b55afa0

File tree

1 file changed

+19
-19
lines changed

1 file changed

+19
-19
lines changed

disk/disk-uclass.c

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -151,34 +151,34 @@ U_BOOT_DRIVER(blk_partition) = {
151151
*/
152152
static struct blk_desc *dev_get_blk(struct udevice *dev)
153153
{
154-
struct blk_desc *block_dev;
154+
struct blk_desc *desc;
155155

156156
switch (device_get_uclass_id(dev)) {
157157
/*
158158
* We won't support UCLASS_BLK with dev_* interfaces.
159159
*/
160160
case UCLASS_PARTITION:
161-
block_dev = dev_get_uclass_plat(dev_get_parent(dev));
161+
desc = dev_get_uclass_plat(dev_get_parent(dev));
162162
break;
163163
default:
164-
block_dev = NULL;
164+
desc = NULL;
165165
break;
166166
}
167167

168-
return block_dev;
168+
return desc;
169169
}
170170

171171
unsigned long disk_blk_read(struct udevice *dev, lbaint_t start,
172172
lbaint_t blkcnt, void *buffer)
173173
{
174-
struct blk_desc *block_dev;
174+
struct blk_desc *desc;
175175
const struct blk_ops *ops;
176176
struct disk_part *part;
177177
lbaint_t start_in_disk;
178178
ulong blks_read;
179179

180-
block_dev = dev_get_blk(dev);
181-
if (!block_dev)
180+
desc = dev_get_blk(dev);
181+
if (!desc)
182182
return -ENOSYS;
183183

184184
ops = blk_get_ops(dev);
@@ -191,51 +191,51 @@ unsigned long disk_blk_read(struct udevice *dev, lbaint_t start,
191191
start_in_disk += part->gpt_part_info.start;
192192
}
193193

194-
if (blkcache_read(block_dev->uclass_id, block_dev->devnum,
195-
start_in_disk, blkcnt, block_dev->blksz, buffer))
194+
if (blkcache_read(desc->uclass_id, desc->devnum, start_in_disk, blkcnt,
195+
desc->blksz, buffer))
196196
return blkcnt;
197197
blks_read = ops->read(dev, start, blkcnt, buffer);
198198
if (blks_read == blkcnt)
199-
blkcache_fill(block_dev->uclass_id, block_dev->devnum,
200-
start_in_disk, blkcnt, block_dev->blksz, buffer);
199+
blkcache_fill(desc->uclass_id, desc->devnum, start_in_disk,
200+
blkcnt, desc->blksz, buffer);
201201

202202
return blks_read;
203203
}
204204

205205
unsigned long disk_blk_write(struct udevice *dev, lbaint_t start,
206206
lbaint_t blkcnt, const void *buffer)
207207
{
208-
struct blk_desc *block_dev;
208+
struct blk_desc *desc;
209209
const struct blk_ops *ops;
210210

211-
block_dev = dev_get_blk(dev);
212-
if (!block_dev)
211+
desc = dev_get_blk(dev);
212+
if (!desc)
213213
return -ENOSYS;
214214

215215
ops = blk_get_ops(dev);
216216
if (!ops->write)
217217
return -ENOSYS;
218218

219-
blkcache_invalidate(block_dev->uclass_id, block_dev->devnum);
219+
blkcache_invalidate(desc->uclass_id, desc->devnum);
220220

221221
return ops->write(dev, start, blkcnt, buffer);
222222
}
223223

224224
unsigned long disk_blk_erase(struct udevice *dev, lbaint_t start,
225225
lbaint_t blkcnt)
226226
{
227-
struct blk_desc *block_dev;
227+
struct blk_desc *desc;
228228
const struct blk_ops *ops;
229229

230-
block_dev = dev_get_blk(dev);
231-
if (!block_dev)
230+
desc = dev_get_blk(dev);
231+
if (!desc)
232232
return -ENOSYS;
233233

234234
ops = blk_get_ops(dev);
235235
if (!ops->erase)
236236
return -ENOSYS;
237237

238-
blkcache_invalidate(block_dev->uclass_id, block_dev->devnum);
238+
blkcache_invalidate(desc->uclass_id, desc->devnum);
239239

240240
return ops->erase(dev, start, blkcnt);
241241
}

0 commit comments

Comments
 (0)