Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System keyboard shortcuts #431

Closed
spajdo opened this issue Sep 5, 2016 · 9 comments
Closed

System keyboard shortcuts #431

spajdo opened this issue Sep 5, 2016 · 9 comments

Comments

@spajdo
Copy link

spajdo commented Sep 5, 2016

Please add support for Sound and Media keyboard shortcuts. For previous/next track and play/pause buttons. It realy miss me.

@EragonJ
Copy link
Owner

EragonJ commented Sep 5, 2016

@spajdo it's supported natively by Kaku itself already, please check

Kaku/bootup.js

Line 70 in d9dfab6

const shortcuts = [

@EragonJ
Copy link
Owner

EragonJ commented Sep 5, 2016

If you found that this doesn't work in your platform / OS, please follow the default format to report your issue here and we'll see how to solve that. Instead, if the comment above does help you, i'll lose this one, thanks :)

@spajdo
Copy link
Author

spajdo commented Sep 6, 2016

Bug

I don't have media buttons on my keyboard and therefore I mapped my own shortcuts to controll media players in my system. All players works with this, but Kaku don't work.

What is your Kaku version ?

1.5.0

What is your OS with version number ?

Ubuntu Gnome 16.04

Which platform you are using to listen to music ?

YouTube

Which track format you are using ?

best video (or best audio)

Please look at this. This is very useful and nice application and only this miss me. Thank you.

@EragonJ
Copy link
Owner

EragonJ commented Sep 6, 2016

@spajdo oh that's interesting scenario ... can you try to use 1.7.0 and see how it works for you ?

@spajdo
Copy link
Author

spajdo commented Sep 6, 2016

In 1.7.0 version is the same.
I send you my shortcuts settings.
In Nuvolaplayer (which I use for google play music) it works fine. I think nuvola is too opensource. Maybe try look at his codes.

screenshot from 2016-09-06 09-46-54

@EragonJ
Copy link
Owner

EragonJ commented Sep 6, 2016

cool thanks @spajdo I checked electron's source code and it seems that they directly read the keyChar you pressed from your keyboard. So take play for example, i think it'll recognize there is one shift+ctrl+space got pressed instead of MediaPlayPause.

Let's keep this open first :)

@EragonJ
Copy link
Owner

EragonJ commented Nov 21, 2018

I'll close this outdated issue first and feel free to reopen if there is any way to bypass this in electron.

@EragonJ EragonJ closed this as completed Nov 21, 2018
@acrisci
Copy link

acrisci commented May 2, 2019

The way to make media keys work on Ubuntu and most other Linux distributions is to implement the MPRIS DBus Specification.

There's a library for that called mpris-service.

You can see a list of implementations here.

@EragonJ
Copy link
Owner

EragonJ commented May 6, 2019

@acrisci thanks i'll give it a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants