From 9adb05447e158771863d9fe46556fa9b809d8488 Mon Sep 17 00:00:00 2001 From: John Bodley <4567245+john-bodley@users.noreply.github.com> Date: Tue, 2 Apr 2024 17:08:42 -0700 Subject: [PATCH] chore(sql_parse): Strip leading/trailing whitespace in Jinja macro extraction (#27842) --- superset/sql_parse.py | 2 +- tests/unit_tests/sql_parse_tests.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/superset/sql_parse.py b/superset/sql_parse.py index 2fab2c26fb3e..30083e484aad 100644 --- a/superset/sql_parse.py +++ b/superset/sql_parse.py @@ -1548,7 +1548,7 @@ def extract_tables_from_jinja_sql(sql: str, database: Database) -> set[Table]: tables.add( Table( *[ - remove_quotes(part) + remove_quotes(part.strip()) for part in node.args[0].value.split(".")[::-1] if len(node.args) == 1 ] diff --git a/tests/unit_tests/sql_parse_tests.py b/tests/unit_tests/sql_parse_tests.py index eae43dd4c35a..d10c9dbe2507 100644 --- a/tests/unit_tests/sql_parse_tests.py +++ b/tests/unit_tests/sql_parse_tests.py @@ -1937,6 +1937,7 @@ def test_sqlstatement() -> None: "macro", [ "latest_partition('foo.bar')", + "latest_partition(' foo.bar ')", # Non-atypical user error which works "latest_sub_partition('foo.bar', baz='qux')", ], )