Improve handling of ~console in user functions

Author: PseudoKnight

src/main/java/com/laytonsmith/core/Static.java

@@ -845,7 +845,11 @@ public static MCOfflinePlayer GetUser(Mixed search, Target t) {
 	public static MCOfflinePlayer GetUser(String search, Target t) {
 		MCOfflinePlayer ofp;
 		if(search.length() > 0 && search.length() <= 16) {
-			ofp = getServer().getOfflinePlayer(search);
+			if(CONSOLE_NAME.equals(search)) {
+				ofp = null;
+			} else {
+				ofp = getServer().getOfflinePlayer(search);
+			}
 		} else {
 			try {
 				ofp = getServer().getOfflinePlayer(GetUUID(search, t));

src/main/java/com/laytonsmith/core/functions/Environment.java

@@ -986,7 +986,15 @@ public Mixed exec(Target t, com.laytonsmith.core.environments.Environment enviro
 			if(!(blockState instanceof MCSkull skull)) {
 				throw new CRERangeException("The block at the specified location is not a skull", t);
 			}
-			MCOfflinePlayer owner = (args[1] instanceof CNull ? null : Static.GetUser(args[1], t));
+			MCOfflinePlayer owner;
+			if(args[1] instanceof CNull) {
+				owner = null;
+			} else {
+				owner = Static.GetUser(args[1], t);
+				if(owner == null) {
+					throw new CRENotFoundException(this.getName() + " could not get offline player: " + args[1].val(), t);
+				}
+			}
 			if(owner != null && args.length == 3) {
 				MCPlayerProfile profile = Static.getServer().getPlayerProfile(owner.getUniqueID(), owner.getName());
 				if(profile != null) {

src/main/java/com/laytonsmith/core/functions/PlayerManagement.java

@@ -5096,12 +5096,15 @@ public Boolean runAsync() {
 
 		@Override
 		public Mixed exec(Target t, Environment environment, Mixed... args) throws ConfigRuntimeException {
-			MCCommandSender cs = environment.getEnv(CommandHelperEnvironment.class).GetCommandSender();
-			MCOfflinePlayer op = null;
+			MCOfflinePlayer op;
 			if(args.length == 1) {
 				op = Static.GetUser(args[0].val(), t);
-			} else if(cs != null) {
-				op = Static.GetUser(cs.getName(), t);
+			} else {
+				op = environment.getEnv(CommandHelperEnvironment.class).GetPlayer();
+				if(op == null) {
+					throw new CREInsufficientArgumentsException(this.getName()
+							+ " requires a player argument when ran from a non-player", t);
+				}
 			}
 			return new CInt((op == null ? 0 : op.getFirstPlayed()), t); // Return 0 for fake/null command senders.
 		}
@@ -5160,12 +5163,15 @@ public Boolean runAsync() {
 
 		@Override
 		public Mixed exec(Target t, Environment environment, Mixed... args) throws ConfigRuntimeException {
-			MCCommandSender cs = environment.getEnv(CommandHelperEnvironment.class).GetCommandSender();
-			MCOfflinePlayer op = null;
+			MCOfflinePlayer op;
 			if(args.length == 1) {
 				op = Static.GetUser(args[0].val(), t);
-			} else if(cs != null) {
-				op = Static.GetUser(cs.getName(), t);
+			} else {
+				op = environment.getEnv(CommandHelperEnvironment.class).GetPlayer();
+				if(op == null) {
+					throw new CREInsufficientArgumentsException(this.getName()
+							+ " requires a player argument when ran from a non-player", t);
+				}
 			}
 			return new CInt((op == null ? 0 : op.getLastPlayed()), t); // Return 0 for fake/null command senders.
 		}