Stop using shell #74
Merged
Stop using shell #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahsmartin
commented
Mar 1, 2024
| @@ -153,11 +153,7 @@ public class StackSymbolicator { | |||
| let strs = addrsArray.map { String($0 + addition, radix: 16) } | |||
| try! strs.joined(separator: "\n").write(toFile: addrsFile, atomically: true, encoding: .utf8) | |||
|
|
|||
| let arch = try? safeShellWithOutput("/usr/bin/file \"\(binary)\"").contains("arm64e") ? "arm64e" : "arm64" | |||
There was a problem hiding this comment.
The arch flag doesn't seem to be needed as long as it isn't a universal binary, and this wasn't making an effort to pick the right arch from a universal binary anyways
noahsmartin
commented
Mar 1, 2024
| @@ -153,11 +153,7 @@ public class StackSymbolicator { | |||
| let strs = addrsArray.map { String($0 + addition, radix: 16) } | |||
| try! strs.joined(separator: "\n").write(toFile: addrsFile, atomically: true, encoding: .utf8) | |||
|
|
|||
| let arch = try? safeShellWithOutput("/usr/bin/file \"\(binary)\"").contains("arm64e") ? "arm64e" : "arm64" | |||
|
|
|||
| try! strs.joined(separator: "\n").write(toFile: addrsFile, atomically: true, encoding: .utf8) | |||
There was a problem hiding this comment.
This file was already written on line 154
trevor-e
approved these changes
Mar 1, 2024
| task.executableURL = URL(fileURLWithPath: executable) | ||
| task.standardInput = nil | ||
|
|
||
| let group = DispatchGroup() |
There was a problem hiding this comment.
nit: can you share the pipe processing logic with safeShellWithOutput()?
noahsmartin
force-pushed
the
stopUsingShell
branch
from
84d9887
to
22283fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.