From e24864363449b3ca9c3ffcea27f72894752f848a Mon Sep 17 00:00:00 2001
From: Sayak Mukhopadhyay <mukhopadhyaysayak@gmail.com>
Date: Fri, 14 Jul 2017 02:04:13 +0530
Subject: [PATCH] Other faction reports fixing

---
 src/modules/discord/commands/bgsReport.ts | 43 +++++++++++++++--------
 1 file changed, 28 insertions(+), 15 deletions(-)

diff --git a/src/modules/discord/commands/bgsReport.ts b/src/modules/discord/commands/bgsReport.ts
index 6e3340c..c04b37a 100644
--- a/src/modules/discord/commands/bgsReport.ts
+++ b/src/modules/discord/commands/bgsReport.ts
@@ -77,6 +77,7 @@ export class BGSReport {
                                             factions.forEach(faction => {
                                                 let factionAcronym = this.acronym(faction.faction_name);
                                                 embed.addField(faction.faction_name, "------------", false);
+                                                let factionPromiseArray = [];
                                                 faction.faction_presence.forEach((faction) => {
                                                     let systemReport = "";
                                                     systemReport += `Current ${factionAcronym} Influence : ${(faction.influence * 100).toFixed(1)}%\n`;
@@ -95,23 +96,35 @@ export class BGSReport {
                                                     }
                                                     systemReport += `Pending ${factionAcronym} States : ${pendingStates}\n`;
                                                     secondaryFactions.forEach(otherFaction => {
-                                                        this.db.model.faction.findOne({ faction_name_lower: otherFaction })
-                                                            .then(otherFaction => {
-                                                                if (otherFaction) {
-                                                                    let systems = otherFaction.faction_presence;
-                                                                    let indexOfSystem = systems.findIndex(x => x.system_name === faction.system_name);
-                                                                    if (indexOfSystem !== -1) {
-                                                                        let factionAcronym = this.acronym(otherFaction.faction_name);
-                                                                        let otherSystem = otherFaction.faction_presence[indexOfSystem];
-                                                                        systemReport += `Current ${factionAcronym} Influence : ${(otherSystem.influence * 100).toFixed(1)}% (Currently in ${otherSystem.state})\n`;
-                                                                    }
-                                                                }
+                                                        factionPromiseArray.push(
+                                                            new Promise((resolve, reject) => {
+                                                                this.db.model.faction.findOne({ faction_name_lower: otherFaction })
+                                                                    .then(otherFaction => {
+                                                                        if (otherFaction) {
+                                                                            let systems = otherFaction.faction_presence;
+                                                                            let indexOfSystem = systems.findIndex(x => x.system_name === faction.system_name);
+                                                                            if (indexOfSystem !== -1) {
+                                                                                let factionAcronym = this.acronym(otherFaction.faction_name);
+                                                                                let otherSystem = otherFaction.faction_presence[indexOfSystem];
+                                                                                systemReport += `Current ${factionAcronym} Influence : ${(otherSystem.influence * 100).toFixed(1)}% (Currently in ${otherSystem.state})\n`;
+                                                                            }
+                                                                        }
+                                                                        resolve(systemReport);
+                                                                    })
+                                                                    .catch(err => {
+                                                                        reject(err);
+                                                                    });
                                                             })
-                                                            .catch(err => {
-                                                                console.log(err);
-                                                            });
+                                                        );
                                                     });
-                                                    embed.addField(faction.system_name, systemReport);
+                                                    console.log(factionPromiseArray);
+                                                    Promise.all(factionPromiseArray)
+                                                        .then(systemReport => {
+                                                            embed.addField(faction.system_name, systemReport);
+                                                        })
+                                                        .catch(err => {
+                                                            console.log(err);
+                                                        })
                                                 });
                                             });
                                             embed.setTimestamp(new Date());